You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by ex...@apache.org on 2025/07/11 17:31:44 UTC

(nifi) branch main updated: NIFI-14742 Replaced for loop with for each loop missed by PMD ForLoopCanBeForeach rule (#10084)

This is an automated email from the ASF dual-hosted git repository.

exceptionfactory pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git


The following commit(s) were added to refs/heads/main by this push:
     new 98aad34223 NIFI-14742 Replaced for loop with for each loop missed by PMD ForLoopCanBeForeach rule (#10084)
98aad34223 is described below

commit 98aad34223e166dac9f9c2b0131ef1336f7fc62f
Author: dan-s1 <ds...@gmail.com>
AuthorDate: Fri Jul 11 13:31:38 2025 -0400

    NIFI-14742 Replaced for loop with for each loop missed by PMD ForLoopCanBeForeach rule (#10084)
    
    Signed-off-by: David Handermann <ex...@apache.org>
---
 .../src/main/java/org/apache/nifi/text/FreeFormTextWriter.java         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/text/FreeFormTextWriter.java b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/text/FreeFormTextWriter.java
index 28d332b6f7..420655d2fb 100644
--- a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/text/FreeFormTextWriter.java
+++ b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/text/FreeFormTextWriter.java
@@ -68,8 +68,7 @@ public class FreeFormTextWriter extends AbstractRecordSetWriter implements Recor
     private void write(final Record record, final OutputStream out, final List<String> columnNames) throws IOException {
         final int numCols = columnNames.size();
         final Map<String, String> values = new HashMap<>(numCols);
-        for (int i = 0; i < numCols; i++) {
-            final String columnName = columnNames.get(i);
+        for (final String columnName : columnNames) {
             final String columnValue = record.getAsString(columnName);
             values.put(columnName, columnValue);
         }