You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/18 17:15:12 UTC

[GitHub] [ratis] JoeCqupt opened a new pull request, #684: RATIS-1627. InstallSnapshotRequests add properties : totalSize

JoeCqupt opened a new pull request, #684:
URL: https://github.com/apache/ratis/pull/684

   ## What changes were proposed in this pull request?
   
   in method : org.apache.ratis.server.leader.InstallSnapshotRequests#newInstallSnapshotRequest; 
   
   it is unnecessary to compute repeatedly the total size of snapshot .
   
   ## What is the link to the Apache JIRA
   
   RATIS-1627. InstallSnapshotRequests add properties : totalSize
   
   https://issues.apache.org/jira/browse/RATIS-1627
   
   ## How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo merged pull request #684: RATIS-1627. InstallSnapshotRequests add properties : totalSize

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #684:
URL: https://github.com/apache/ratis/pull/684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo closed pull request #684: RATIS-1627. InstallSnapshotRequests add properties : totalSize

Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #684: RATIS-1627. InstallSnapshotRequests add properties : totalSize
URL: https://github.com/apache/ratis/pull/684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo commented on a diff in pull request #684: RATIS-1627. InstallSnapshotRequests add properties : totalSize

Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #684:
URL: https://github.com/apache/ratis/pull/684#discussion_r923706197


##########
ratis-server/src/main/java/org/apache/ratis/server/leader/InstallSnapshotRequests.java:
##########
@@ -59,6 +59,8 @@ class InstallSnapshotRequests implements Iterable<InstallSnapshotRequestProto> {
   private int fileIndex = 0;
   /** The current file. */
   private FileChunkReader current;
+  /** The total size of snapshot files. */
+  private long totalSize;

Review Comment:
   Please make it final and move to next to the other final fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org