You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/08/11 11:09:14 UTC
[GitHub] [jackrabbit-oak] rombert commented on a diff in pull request #629: OAK-9846: Emit origin for each checker report
rombert commented on code in PR #629:
URL: https://github.com/apache/jackrabbit-oak/pull/629#discussion_r943361926
##########
oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/ErrorHolder.java:
##########
@@ -27,16 +27,16 @@ class ErrorHolder {
private static final int FAIL_IMMEDIATELY_THRESHOLD = 100;
private final List<String> errors = new ArrayList<>();
- public void report(MountedNodeStore mountedStore, String path, String error) {
- errors.add(String.format("For NodeStore mount %s, path %s, encountered the following problem: '%s'", mountedStore.getMount().getName(), path, error));
+ public void report(MountedNodeStore mountedStore, String path, String error, MountedNodeStoreChecker<?> checker) {
Review Comment:
I think 'not versioned but exported' is the general Oak policy. I don't agree, but this is what we settled on.
For this particular change I have no backwards compatibility concerns since I did not see any exported APIs changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org