You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/10/30 21:44:40 UTC
Re: [PR] [SPARK-45729][PYTHON][DOCS] Fix PySpark testing guide links [spark]
allisonwang-db commented on code in PR #43587:
URL: https://github.com/apache/spark/pull/43587#discussion_r1376834363
##########
python/docs/source/getting_started/testing_pyspark.ipynb:
##########
@@ -273,7 +273,7 @@
"source": [
"### Option 3: Using [Pytest](https://docs.pytest.org/en/7.1.x/contents.html)\n",
"\n",
- "We can also write our tests with `pytest`, which is one of the most popular Python testing frameworks. For more information about `pytest`, see the docs here: https://docs.pytest.org/en/7.1.x/contents.html.\n",
+ "We can also write our tests with `pytest`, which is one of the most popular Python testing frameworks. For more information about `pytest`, see the docs [here](https://docs.pytest.org/en/7.1.x/contents.html).\n",
Review Comment:
```suggestion
"We can also write our tests with `pytest`, which is one of the most popular Python testing frameworks.\n",
```
##########
python/docs/source/getting_started/testing_pyspark.ipynb:
##########
@@ -9,7 +9,7 @@
"\n",
"This guide is a reference for writing robust tests for PySpark code.\n",
"\n",
- "To view the docs for PySpark test utils, see here. To see the code for PySpark built-in test utils, check out the Spark repository here. To see the JIRA board tickets for the PySpark test framework, see here."
+ "To view the docs for PySpark test utils, see here. To see the code for PySpark built-in test utils, check out the Spark repository here. To see the JIRA board tickets for the PySpark test framework, see [here](https://issues.apache.org/jira/browse/SPARK-44042)."
Review Comment:
I think we can just mention the testing utility functions' API doc, and remove the rest of the external links
```suggestion
"To view the docs for PySpark test utils, see [here](https://spark.apache.org/docs/latest/api/python/reference/api/pyspark.testing.assertDataFrameEqual.html. "
```
##########
python/docs/source/getting_started/testing_pyspark.ipynb:
##########
@@ -193,7 +193,7 @@
"### Option 2: Using [Unit Test](https://docs.python.org/3/library/unittest.html)\n",
"For more complex testing scenarios, you may want to use a testing framework.\n",
"\n",
- "One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. For more information about the `unittest` library, see here: https://docs.python.org/3/library/unittest.html. \n",
+ "One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. For more information about the `unittest` library, see [here](https://docs.python.org/3/library/unittest.html). \n",
Review Comment:
```suggestion
"One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. \n",
```
##########
python/docs/source/getting_started/testing_pyspark.ipynb:
##########
@@ -193,7 +193,7 @@
"### Option 2: Using [Unit Test](https://docs.python.org/3/library/unittest.html)\n",
"For more complex testing scenarios, you may want to use a testing framework.\n",
"\n",
- "One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. For more information about the `unittest` library, see here: https://docs.python.org/3/library/unittest.html. \n",
+ "One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. For more information about the `unittest` library, see [here](https://docs.python.org/3/library/unittest.html). \n",
Review Comment:
```suggestion
"One of the most popular testing framework options is unit tests. Let’s walk through how you can use the built-in Python `unittest` library to write PySpark tests. \n",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org