(ofbiz-framework) branch trunk updated: Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new bc92ac06fa Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)
bc92ac06fa is described below

commit bc92ac06fab17186ca63b6e96adcf5037e87f796
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Sat Apr 27 18:55:16 2024 +0200

    Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)
    
    When a spider bot gets to certain non-sense URIs under sfa app (it seems only
    for sfa, did not dig further it's non-sense anyway) like discovered in
    trunk demo log today: <</sfa/control/setSessionTimeZone?tzId=America/Ensenada>>
    the <<Could not find PortalPage with portalPageId []>> error shows
    
    Then we don't need to clutter the log with useless error information.
    This keeps it ASAP by simply returning the portalPage if it's null.
---
 .../src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
index fd38ba1c26..b05c19dfb9 100644
--- a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
+++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
@@ -1947,7 +1947,6 @@ public abstract class ModelScreenWidget extends ModelWidget {
             if (portalPage == null) {
                 String errMsg = "Could not find PortalPage with portalPageId [" + expandedPortalPageId + "] ";
                 Debug.logError(errMsg, MODULE);
-                throw new RuntimeException(errMsg);
             }
             return portalPage;
         }