[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1088: Lightweight context without init / start phases

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #1088: Lightweight context without init / start phases
URL: https://github.com/apache/camel-quarkus/pull/1088#discussion_r408668966
 
 

 ##########
 File path: extensions-core/reactive-executor/deployment/src/main/java/org/apache/camel/quarkus/reactive/executor/deployment/BuildProcessor.java
 ##########
 @@ -25,9 +25,16 @@
 import org.apache.camel.quarkus.reactive.executor.ReactiveExecutorRecorder;
 
 public class BuildProcessor {
+    @Record(value = ExecutionTime.STATIC_INIT, optional = true)
+    @BuildStep(onlyIf = Flags.MainEnabled.class)
+    CamelReactiveExecutorBuildItem reactiveExecutor(ReactiveExecutorRecorder recorder) {
+        return new CamelReactiveExecutorBuildItem(recorder.createReactiveExecutor());
+    }
+
     @Record(value = ExecutionTime.RUNTIME_INIT, optional = true)
     @BuildStep(onlyIf = Flags.MainEnabled.class)
-    CamelReactiveExecutorBuildItem reactiveExecutor(ReactiveExecutorRecorder recorder, VertxBuildItem vertx) {
-        return new CamelReactiveExecutorBuildItem(recorder.createReactiveExecutor(vertx.getVertx()));
+    void initReactiveExecutor(ReactiveExecutorRecorder recorder, CamelReactiveExecutorBuildItem executor,
+            VertxBuildItem vertx) {
 
 Review comment:
   I think we need a sort of barrier to avoid this to be executed after main is started

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services