[GitHub] [spark] MaxGekk commented on a change in pull request #31216: [SPARK-34143][SQL][TESTS] Fix adding partitions to fully partitioned v2 tables

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31216:
URL: https://github.com/apache/spark/pull/31216#discussion_r559346118



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -44,4 +44,13 @@ class AlterTableAddPartitionSuite
       checkPartitions(t, Map("p1" -> ""))
     }
   }
+
+  test("SPARK-34143: add a partition to fully partitioned table") {
+    withNamespaceAndTable("ns", "tbl") { t =>
+      sql(s"CREATE TABLE $t (p0 INT, p1 STRING) $defaultUsing PARTITIONED BY (p0, p1)")

Review comment:
       I think, v2 impl should decide allowed it or not. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org