You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mime4j-dev@james.apache.org by "Oleg Kalnichevski (JIRA)" <mi...@james.apache.org> on 2009/12/01 21:53:21 UTC
[jira] Created: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
---------------------------------------------------------------------------------------
Key: MIME4J-141
URL: https://issues.apache.org/jira/browse/MIME4J-141
Project: JAMES Mime4j
Issue Type: Bug
Reporter: Oleg Kalnichevski
DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Oleg Kalnichevski (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved MIME4J-141.
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Fixed in SVN trunk. Please review.
Oleg
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Stefano Bagnara (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara reopened MIME4J-141:
------------------------------------
I'm reopening this, in view of MIME4J-146.
IMO we should use body and raw consistently. IMO if we simply change the RawField to unfold the body before returing getBody then we should simply leave the DelegatingFieldParser to only accept unfolded body. If you have folded text then it is raw and not body.
Making this more clear now will help us when we'll try to make mime4j better by supporting encoded-words and more during parsing and DOM "export".
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Markus Wiederkehr (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784453#action_12784453 ]
Markus Wiederkehr commented on MIME4J-141:
------------------------------------------
Look okay to me.
I guess the MimeUtil.unfold() call in AbstractField line 155 does not make much sense after your change.
At least all tests seem to pass if the call gets removed.
Opinions?
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Oleg Kalnichevski (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784965#action_12784965 ]
Oleg Kalnichevski commented on MIME4J-141:
------------------------------------------
Makes sense. Removed. Please review.
Oleg
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Stefano Bagnara (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794721#action_12794721 ]
Stefano Bagnara commented on MIME4J-141:
----------------------------------------
Please see the fix for MIME4J-146. I this the currently committed code fix this stuff in the expected way.
All tests still pass.
If you have external code depending on the previous behaviour please provide a testcase so that we can discuss the need of body to be unfolded in the parser and not by RawField.
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MIME4J-141) DefaultFieldParser /
DelegatingFieldParser incorrectly reject folded headers as invalid
Posted by "Oleg Kalnichevski (JIRA)" <mi...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved MIME4J-141.
--------------------------------------
Resolution: Fixed
Works for me.
Oleg
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid
> ---------------------------------------------------------------------------------------
>
> Key: MIME4J-141
> URL: https://issues.apache.org/jira/browse/MIME4J-141
> Project: JAMES Mime4j
> Issue Type: Bug
> Reporter: Oleg Kalnichevski
> Fix For: 0.7
>
>
> DefaultFieldParser / DelegatingFieldParser incorrectly reject folded headers as invalid. Value of the header field must be unfolded prior to parsing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.