You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/12 06:23:01 UTC

[GitHub] [incubator-apisix] Donghui0 opened a new issue #1704: bug: cors plugin return repeated cross-domain header 

Donghui0 opened a new issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704


   ### Issue description
   When the backend also returns cross-domain headers, using cors plugin will cause duplicate cross-domain headers
   for example:
       backend code set header:
   
   ![image](https://user-images.githubusercontent.com/7134928/84471298-a37b9780-acb7-11ea-8baa-62f1cd54db5f.png)
   
       enable cors plugin, then response header like this :
   
   ![image](https://user-images.githubusercontent.com/7134928/84471367-c60db080-acb7-11ea-966a-3bd503f72ab4.png)
   
       
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 1.2
   * OS: centos7.6
   
   
   ### What's the expected result?
   remove duplicate headers
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1704: bug: cors plugin return repeated cross-domain header

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704#issuecomment-643882368


   If we want to remove the duplicate header, should we keep the upstream or the newly set value of the plugin?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1704: bug: cors plugin return repeated cross-domain header

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704#issuecomment-643991851


   default value is false or ture for `is_overwrite_upstream`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1704: bug: cors plugin return repeated cross-domain header

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704#issuecomment-643967482


   @ShiningRush please take a look. Myabe we can overwrite the headers from upstream?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] ShiningRush commented on issue #1704: bug: cors plugin return repeated cross-domain header

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704#issuecomment-644005909


   I think `false` is better,  upstream should be high priority


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] ShiningRush commented on issue #1704: bug: cors plugin return repeated cross-domain header

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #1704:
URL: https://github.com/apache/incubator-apisix/issues/1704#issuecomment-643970265


   I think we can add a parameter to control if overwrite the headers of upstream, such as "is_overwrite_upstream".
   @membphis @moonming How about it ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org