You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/18 18:27:28 UTC

[GitHub] [zookeeper] HoustonPutman opened a new pull request, #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

HoustonPutman opened a new pull request, #1863:
URL: https://github.com/apache/zookeeper/pull/1863

   This is backwards compatible, since the new method on the `Testable` interface defaults to a no-op.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zookeeper] maoling commented on pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

Posted by GitBox <gi...@apache.org>.
maoling commented on PR #1863:
URL: https://github.com/apache/zookeeper/pull/1863#issuecomment-1120612215

   If no other concerns, I'll merge it at this weekend(05-14)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zookeeper] maoling commented on pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

Posted by GitBox <gi...@apache.org>.
maoling commented on PR #1863:
URL: https://github.com/apache/zookeeper/pull/1863#issuecomment-1127193643

   @HoustonPutman 
   
   Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zookeeper] HoustonPutman commented on pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1863:
URL: https://github.com/apache/zookeeper/pull/1863#issuecomment-1164556245

   @maoling could we possibly backport this to the 3.8.x (and possibly 3.7.x branches)? It's backwards compatible, and would be very nice to get into a Solr version sometime soon!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zookeeper] maoling closed pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface
URL: https://github.com/apache/zookeeper/pull/1863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zookeeper] asfgit closed pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1863: ZOOKEEPER-4519: Add closeSocket method to Testable interface
URL: https://github.com/apache/zookeeper/pull/1863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org