[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11777 )

Change subject: IMPALA-7714: remove unsafe code from signal handlers
......................................................................

IMPALA-7714: remove unsafe code from signal handlers

IMPALA-6271 added LOG statements to some signal handlers and an exit()
call to a different signal handler. These functions are not async-signal
safe.

The fixes are:
* Use the write system call directly. I tried using glog's RAW_LOG
  functionality but had major issues getting it to work.
* Call _exit() directly instead of exit() so that static destructors
  are not run. This is the same default behaviour as SIGTERM. This
  wans't necessary to prevent this specific crash.

Testing:
Could reproduce the crash by looping
tests/custom_cluster/test_local_catalog.py until a minidump was
produced. After this fix it did not reproduce after looping for
a few hours.

Ran exhaustive build.

Change-Id: I52037d6510b9b34ec33d3a8b5492226aee1b9d92
---
M be/src/common/init.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/11777/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52037d6510b9b34ec33d3a8b5492226aee1b9d92
Gerrit-Change-Number: 11777
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>