You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Jennifer A Thompson (Created) (JIRA)" <de...@tuscany.apache.org> on 2012/02/20 23:33:34 UTC

[jira] [Created] (TUSCANY-4018) JMS TransportServiceInterceptor using wrong values to set JMS headers in producer

JMS TransportServiceInterceptor using wrong values to set JMS headers in producer
---------------------------------------------------------------------------------

                 Key: TUSCANY-4018
                 URL: https://issues.apache.org/jira/browse/TUSCANY-4018
             Project: Tuscany
          Issue Type: Bug
          Components: Java SCA JMS Binding Extension
    Affects Versions: Java-SCA-2.x
            Reporter: Jennifer A Thompson
             Fix For: Java-SCA-2.x


In TransportServiceInterceptor.invokeResponse is setting the effective TimeToLive, Priority in the response message, but when the values are set in the producer, the values from the request are used, potentially leading to an incorrect value. So the following:

             // Set jms header attributes in producer, not message.
            int deliveryMode = requestJMSMsg.getJMSDeliveryMode();
            producer.setDeliveryMode(deliveryMode);
            int deliveryPriority = requestJMSMsg.getJMSPriority();
            producer.setPriority(deliveryPriority);
            long timeToLive = requestJMSMsg.getJMSExpiration();
            producer.setTimeToLive(timeToLive);


Should be:

            // Set jms header attributes in producer, not message.
            producer.setDeliveryMode(responseJMSMsg.getJMSDeliveryMode());
            producer.setPriority(responseJMSMsg.getJMSPriority());
            producer.setTimeToLive(responseJMSMsg.getJMSExpiration());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TUSCANY-4018) JMS TransportServiceInterceptor using wrong values to set JMS headers in producer

Posted by "Simon Laws (Closed) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws closed TUSCANY-4018.
-------------------------------

    Resolution: Fixed

Committed at revision: 1291715. Thanks for the patch Jennifer.
                
> JMS TransportServiceInterceptor using wrong values to set JMS headers in producer
> ---------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4018
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4018
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>            Assignee: Simon Laws
>             Fix For: Java-SCA-2.x
>
>         Attachments: Tuscany-4018.patch
>
>
> In TransportServiceInterceptor.invokeResponse is setting the effective TimeToLive, Priority in the response message, but when the values are set in the producer, the values from the request are used, potentially leading to an incorrect value. So the following:
>              // Set jms header attributes in producer, not message.
>             int deliveryMode = requestJMSMsg.getJMSDeliveryMode();
>             producer.setDeliveryMode(deliveryMode);
>             int deliveryPriority = requestJMSMsg.getJMSPriority();
>             producer.setPriority(deliveryPriority);
>             long timeToLive = requestJMSMsg.getJMSExpiration();
>             producer.setTimeToLive(timeToLive);
> Should be:
>             // Set jms header attributes in producer, not message.
>             producer.setDeliveryMode(responseJMSMsg.getJMSDeliveryMode());
>             producer.setPriority(responseJMSMsg.getJMSPriority());
>             producer.setTimeToLive(responseJMSMsg.getJMSExpiration());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TUSCANY-4018) JMS TransportServiceInterceptor using wrong values to set JMS headers in producer

Posted by "Simon Laws (Assigned) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws reassigned TUSCANY-4018:
-----------------------------------

    Assignee: Simon Laws
    
> JMS TransportServiceInterceptor using wrong values to set JMS headers in producer
> ---------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4018
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4018
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>            Assignee: Simon Laws
>             Fix For: Java-SCA-2.x
>
>         Attachments: Tuscany-4018.patch
>
>
> In TransportServiceInterceptor.invokeResponse is setting the effective TimeToLive, Priority in the response message, but when the values are set in the producer, the values from the request are used, potentially leading to an incorrect value. So the following:
>              // Set jms header attributes in producer, not message.
>             int deliveryMode = requestJMSMsg.getJMSDeliveryMode();
>             producer.setDeliveryMode(deliveryMode);
>             int deliveryPriority = requestJMSMsg.getJMSPriority();
>             producer.setPriority(deliveryPriority);
>             long timeToLive = requestJMSMsg.getJMSExpiration();
>             producer.setTimeToLive(timeToLive);
> Should be:
>             // Set jms header attributes in producer, not message.
>             producer.setDeliveryMode(responseJMSMsg.getJMSDeliveryMode());
>             producer.setPriority(responseJMSMsg.getJMSPriority());
>             producer.setTimeToLive(responseJMSMsg.getJMSExpiration());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TUSCANY-4018) JMS TransportServiceInterceptor using wrong values to set JMS headers in producer

Posted by "Jennifer A Thompson (Updated) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jennifer A Thompson updated TUSCANY-4018:
-----------------------------------------

    Attachment: Tuscany-4018.patch
    
> JMS TransportServiceInterceptor using wrong values to set JMS headers in producer
> ---------------------------------------------------------------------------------
>
>                 Key: TUSCANY-4018
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-4018
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>             Fix For: Java-SCA-2.x
>
>         Attachments: Tuscany-4018.patch
>
>
> In TransportServiceInterceptor.invokeResponse is setting the effective TimeToLive, Priority in the response message, but when the values are set in the producer, the values from the request are used, potentially leading to an incorrect value. So the following:
>              // Set jms header attributes in producer, not message.
>             int deliveryMode = requestJMSMsg.getJMSDeliveryMode();
>             producer.setDeliveryMode(deliveryMode);
>             int deliveryPriority = requestJMSMsg.getJMSPriority();
>             producer.setPriority(deliveryPriority);
>             long timeToLive = requestJMSMsg.getJMSExpiration();
>             producer.setTimeToLive(timeToLive);
> Should be:
>             // Set jms header attributes in producer, not message.
>             producer.setDeliveryMode(responseJMSMsg.getJMSDeliveryMode());
>             producer.setPriority(responseJMSMsg.getJMSPriority());
>             producer.setTimeToLive(responseJMSMsg.getJMSExpiration());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira