You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/06/30 17:08:21 UTC
[GitHub] flink pull request #4240: [FLINK-7058] Fix scala-2.10 dependencies
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4240
[FLINK-7058] Fix scala-2.10 dependencies
First commit is from #4209 and should be ignored in this PR
Before fixup:
```
$ mvn dependency:tree -pl flink-scala | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
$ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
$ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
```
After fixup:
```
$ mvn dependency:tree -pl flink-scala | grep quasi
$ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
$ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink scala210
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4240
----
commit a17b0d4aee3c116761871513b2ef073bf8a98750
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-06-23T11:41:55Z
[FLINK-7030] Build with scala-2.11 by default
commit 58a3b7b0a936da0148de4ddb5b9a6b2c3bccc335
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-06-30T16:19:59Z
[FLINK-7058] Fix scala-2.10 dependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
@aljoscha Yeah, so this doesn't affect 1.3. In 1.3 scala 2.10 is still the default, so it needs the reverse logic of this PR, which, well, is the one that was present in 1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4240
This is not relevant for the `release-1.3` branch? (I'm asking because that one still has some issues)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4240
@zentol rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4240
Perfect! (I mean the "making it a blocker and fixing it" part, not the "it being broken" part). 😅
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4240
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
LGTM, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
You can rebase this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
merging to master,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
or rather it affects it in a different way. What we _try_ is to have a dependency by default but removed in specific profile, which is just not possible with maven.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
I made this a blocker since it means you cannot build 1.3 with the scala 2.11 profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
@aljoscha It is also a problem for 1.3. It's even worse since it still uses the scala.binary.version property, which thus may try to fetch a 2.11 version of quasiquotes which just doesn't exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---