You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/04 21:33:47 UTC
[GitHub] [incubator-superset] qyra opened a new issue #9990: SQL Lab editor shortcuts override other common shortcuts
qyra opened a new issue #9990:
URL: https://github.com/apache/incubator-superset/issues/9990
The keyboard shortcuts in the "SQL Editor" view cause issues while editing because they override common text editing and browser shortcut conventions. I've had issues with them in Chromium and Firefox on Linux, and a colleague has had issues in Safari on a mac as well as well.
On Chrome:
Control-X is usually "cut" in a text box, in the editor it has been overridden to stop the query.
Control-F (find) is overridden and I have no idea what it was changed to (I don't see it documented)
Also, the "Keyboard Shortcuts" widget says that Control-T should open a new query tab but it actually opens a new browser tab so whatever override is attempted there doesn't work - but overriding standard browser shortcuts doesn't seem great so I would argue this is a feature, not a bug.
On Safari:
On safari Cmd-X still works for "cut" so presumably the shortcuts treat control and command differently. Cmd-F (find) is still broken.
Just for completeness the following work as expected:
Control-C (copy), Control-V (paste), Control-Z (undo), Control-Y (redo), Control-A (select all), Control-/ (comment code)
### Suggested Fix
Any of the following would be good:
- Pick new default keyboard shortcuts that do not override common text and browser shortcuts
- Allow changing individual shortcuts permanently (Either with some superset config, or with a user preference)
- If a keyboard shortcut change menu is too much work for this, being able to just disable individual shortcuts would also work as a stopgap.
### Server Environment
Superset 0.36.0
Python 3.6.9
Flask 1.1.2
Werkzeug 1.0.1
### Browser
Chromium on Linux, Version 83.0.4103.61
### Checklist
- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9990: SQL Lab editor shortcuts override other common shortcuts
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9990:
URL: https://github.com/apache/incubator-superset/issues/9990#issuecomment-670838389
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rumbin commented on issue #9990: SQL Lab editor shortcuts override other common shortcuts
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #9990:
URL: https://github.com/apache/incubator-superset/issues/9990#issuecomment-670840883
Do not close, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #9990: SQL Lab editor shortcuts override other common shortcuts
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #9990:
URL: https://github.com/apache/incubator-superset/issues/9990#issuecomment-639131316
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.81. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org