[jira] [Commented] (KARAF-1064) BootstrapLogManager does not reuse the instantiated Handler

["Ioannis Canellos (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159996#comment-13159996 ] 

Ioannis Canellos commented on KARAF-1064:
-----------------------------------------

Looks good to me.

I would make the getHandler method synchronized, just to be 100% that there isn't going to be a second handler created.
                
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
>                 Key: KARAF-1064
>                 URL: https://issues.apache.org/jira/browse/KARAF-1064
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-core
>    Affects Versions: 2.2.4, 3.0.0
>            Reporter: Álvaro Alda
>            Assignee: Andreas Pieber
>             Fix For: 2.2.5, 3.0.0
>
>         Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one. 
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira