You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/12/20 16:36:43 UTC

Review Request 54903: BE changes needed for SNMP Ambari MIB support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54903/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-19257
    https://issues.apache.org/jira/browse/AMBARI-19257


Repository: ambari


Description
-------

Replace 
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = STRING: "CRITICAL"
with
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = INTEGER: 3


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java 62ef31a 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 3bb70e2 
  ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java 6cf4990 

Diff: https://reviews.apache.org/r/54903/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 54903: BE changes needed for SNMP Ambari MIB support

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54903/#review159853
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 20, 2016, 11:36 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54903/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 11:36 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19257
>     https://issues.apache.org/jira/browse/AMBARI-19257
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replace 
> SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = STRING: "CRITICAL"
> with
> SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = INTEGER: 3
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java 62ef31a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 3bb70e2 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java 6cf4990 
> 
> Diff: https://reviews.apache.org/r/54903/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 54903: BE changes needed for SNMP Ambari MIB support

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54903/
-----------------------------------------------------------

(Updated \u0414\u0435\u043a. 23, 2016, 2:46 \u043f.\u043f.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-19257
    https://issues.apache.org/jira/browse/AMBARI-19257


Repository: ambari


Description
-------

Replace 
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = STRING: "CRITICAL"
with
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = INTEGER: 3


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java 62ef31a 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 3bb70e2 
  ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java 6cf4990 

Diff: https://reviews.apache.org/r/54903/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen