You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/23 10:04:45 UTC
[GitHub] [incubator-shenyu] qifanyyy opened a new pull request, #3609: [GSoC 2022] Shenyu add logging-kafka plugin #2917
qifanyyy opened a new pull request, #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609
<!-- Describe your PR here; eg. Fixes #issueNo -->
- In this pull request, the updated license includes Kafka dependency.
- The Kafka logging plugin is implemented
- shenyu-spring-boot-starter-plugin-logging-kafka is implemented
- ShenyuThreadPoolExecutor is updated in AbstractLogCollector.java
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3609: [GSoC 2022] Shenyu add logging-kafka plugin #2917
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#issuecomment-1164266781
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3609](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44e33cb) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/d24fb98e5fe23bbe56c14ebf64fb01fd7ed1c601?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d24fb98) will **decrease** coverage by `0.43%`.
> The diff coverage is `65.28%`.
```diff
@@ Coverage Diff @@
## master #3609 +/- ##
============================================
- Coverage 62.57% 62.14% -0.44%
- Complexity 5710 5777 +67
============================================
Files 870 887 +17
Lines 24076 24583 +507
Branches 2196 2242 +46
============================================
+ Hits 15066 15276 +210
- Misses 7610 7852 +242
- Partials 1400 1455 +55
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/logging/kafka/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...plugin/logging/kafka/constant/LoggingConstant.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvY29uc3RhbnQvTG9nZ2luZ0NvbnN0YW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...henyu/plugin/logging/kafka/LoggingKafkaPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvTG9nZ2luZ0thZmthUGx1Z2luLmphdmE=) | `22.72% <22.72%> (ø)` | |
| [...gin/logging/kafka/kafka/KafkaLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2Eva2Fma2EvS2Fma2FMb2dDb2xsZWN0Q2xpZW50LmphdmE=) | `34.69% <34.69%> (ø)` | |
| [.../logging/kafka/body/LoggingServerHttpResponse.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlc3BvbnNlLmphdmE=) | `53.19% <53.19%> (ø)` | |
| [...e/shenyu/plugin/logging/kafka/body/BodyWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvYm9keS9Cb2R5V3JpdGVyLmphdmE=) | `55.17% <55.17%> (ø)` | |
| [...gin/logging/kafka/utils/LogCollectConfigUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvdXRpbHMvTG9nQ29sbGVjdENvbmZpZ1V0aWxzLmphdmE=) | `66.66% <66.66%> (ø)` | |
| [...yu/plugin/logging/kafka/utils/LogCollectUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvdXRpbHMvTG9nQ29sbGVjdFV0aWxzLmphdmE=) | `66.66% <66.66%> (ø)` | |
| [...g/kafka/handler/LoggingKafkaPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvaGFuZGxlci9Mb2dnaW5nS2Fma2FQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `72.00% <72.00%> (ø)` | |
| [...nyu/plugin/logging/kafka/AbstractLogCollector.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvQWJzdHJhY3RMb2dDb2xsZWN0b3IuamF2YQ==) | `79.54% <79.54%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3609/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d24fb98...44e33cb](https://codecov.io/gh/apache/incubator-shenyu/pull/3609?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] JooKS-me commented on pull request #3609: [GSoC 2022] Shenyu add logging-kafka plugin #2917
Posted by GitBox <gi...@apache.org>.
JooKS-me commented on PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#issuecomment-1166199894
@qifanyyy Pls merge master to resolve integration-test error, see #3611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] HaiqiQin commented on a diff in pull request #3609: [ISSUE #2917] Shenyu add logging-kafka plugin
Posted by GitBox <gi...@apache.org>.
HaiqiQin commented on code in PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#discussion_r906745091
##########
shenyu-common/src/main/java/org/apache/shenyu/common/enums/PluginEnum.java:
##########
@@ -137,6 +137,11 @@ public enum PluginEnum {
*/
LOGGING_ROCKETMQ(170, 0, "loggingRocketMQ"),
+ /**
+ * Logging RocketMQ plugin enum.
Review Comment:
should kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] qifanyyy commented on a diff in pull request #3609: [ISSUE #2917] Shenyu add logging-kafka plugin
Posted by GitBox <gi...@apache.org>.
qifanyyy commented on code in PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#discussion_r906763378
##########
shenyu-common/src/main/java/org/apache/shenyu/common/enums/PluginEnum.java:
##########
@@ -137,6 +137,11 @@ public enum PluginEnum {
*/
LOGGING_ROCKETMQ(170, 0, "loggingRocketMQ"),
+ /**
+ * Logging RocketMQ plugin enum.
Review Comment:
Noted. Will be updated in the next pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] qicz commented on pull request #3609: [GSoC 2022] Shenyu add logging-kafka plugin #2917
Posted by GitBox <gi...@apache.org>.
qicz commented on PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#issuecomment-1164230176
@qifanyyy pls check style
`Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project shenyu-common: You have 1 Checkstyle violation. -> [Help 1]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] qifanyyy commented on pull request #3609: [GSoC 2022] Shenyu add logging-kafka plugin #2917
Posted by GitBox <gi...@apache.org>.
qifanyyy commented on PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609#issuecomment-1164237485
Yes, tried to resolve conflicts with other pull request and the style is not matched when resolving conflicts, it has been resolved.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] tuohai666 merged pull request #3609: [ISSUE #2917] Shenyu add logging-kafka plugin
Posted by GitBox <gi...@apache.org>.
tuohai666 merged PR #3609:
URL: https://github.com/apache/incubator-shenyu/pull/3609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org