You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by vegaed <gi...@git.apache.org> on 2016/10/11 18:12:30 UTC

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

GitHub user vegaed opened a pull request:

    https://github.com/apache/nifi/pull/1125

    NIFI-2872 Create PutCloudwatchMetric Processor

    https://issues.apache.org/jira/browse/NIFI-2872

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vegaed/nifi NIFI-2872

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
    
----
commit 18dca0059c7b9ce39b368968d4813717de77e07b
Author: Edgardo <ed...@nextcentury.com>
Date:   2016-10-11T18:07:42Z

    NIFI-2872 Create PutCloudwatchMetric Processor
    
    https://issues.apache.org/jira/browse/NIFI-2872

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by vegaed <gi...@git.apache.org>.
Github user vegaed commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @jvwing You know why the appveyor build is failing. I didn't touch any of the S2S code. Is it something I should worry about?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by vegaed <gi...@git.apache.org>.
Github user vegaed commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @jvwing Thanks for the review. Just fixed those issues up. Only reason I didn't use the RELs from AbstractAWSProcessor is because it is a deprecated class, but if it standard practice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    I expect so :).  The latest changes look good, thanks for those. I'm going to do a bit more testing, and if everything goes well, I'll merge it this evening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1125#discussion_r83092101
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java ---
    @@ -0,0 +1,203 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.aws.cloudwatch;
    +
    +import com.amazonaws.ClientConfiguration;
    +import com.amazonaws.auth.AWSCredentials;
    +import com.amazonaws.auth.AWSCredentialsProvider;
    +import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
    +import com.amazonaws.services.cloudwatch.model.MetricDatum;
    +import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
    +import org.apache.nifi.annotation.behavior.SupportsBatching;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
    +
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +
    +@SupportsBatching
    +@InputRequirement(Requirement.INPUT_REQUIRED)
    +@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
    +@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
    +public class PutCloudWatchMetric extends AbstractAWSCredentialsProviderProcessor<AmazonCloudWatchClient> {
    +
    +    public static final Set<Relationship> relationships = Collections.unmodifiableSet(
    +            new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
    +
    +    private static final Validator DOUBLE_VALIDATOR = new Validator() {
    +        @Override
    +        public ValidationResult validate(String subject, String input, ValidationContext context) {
    +            if (context.isExpressionLanguageSupported(subject) && context.isExpressionLanguagePresent(input)) {
    +                return (new ValidationResult.Builder()).subject(subject).input(input).explanation("Expression Language Present").valid(true).build();
    +            } else {
    +                String reason = null;
    +
    +                try {
    +                    Double.parseDouble(input);
    +                } catch (NumberFormatException var6) {
    +                    reason = "not a valid Double";
    +                }
    +
    +                return (new ValidationResult.Builder()).subject(subject).input(input).explanation(reason).valid(reason == null).build();
    +            }
    +        }
    +    };
    +
    +    public static final PropertyDescriptor NAMESPACE = new PropertyDescriptor.Builder()
    +            .name("Namespace")
    +            .displayName("Namespace")
    +            .description("The namespace for the metric data for CloudWatch")
    +            .required(true)
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor METRIC_NAME = new PropertyDescriptor.Builder()
    +            .name("MetricName")
    +            .displayName("MetricName")
    +            .description("The name of the metric")
    +            .expressionLanguageSupported(true)
    +            .required(true)
    +            .addValidator(new StandardValidators.StringLengthValidator(1, 255))
    +            .build();
    +
    +    public static final PropertyDescriptor VALUE = new PropertyDescriptor.Builder()
    +            .name("Value")
    +            .displayName("Value")
    +            .description("The value for the metric. Must be a double")
    +            .expressionLanguageSupported(true)
    +            .required(true)
    +            .addValidator(DOUBLE_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor TIMESTAMP = new PropertyDescriptor.Builder()
    +            .name("Timestamp")
    +            .displayName("Timestamp")
    +            .description("A point in time expressed as the number of milliseconds since Jan 1, 1970 00:00:00 UTC. If not specified, the default value is set to the time the metric data was received")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.LONG_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor UNIT = new PropertyDescriptor.Builder()
    +            .name("Unit")
    +            .displayName("Unit")
    +            .description("The unit of the metric. (e.g Seconds, Bytes, Megabytes, Percent, Count,  Kilobytes/Second, Terabits/Second, Count/Second) For details see http://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final List<PropertyDescriptor> properties =
    +            Collections.unmodifiableList(
    +                    Arrays.asList(NAMESPACE, METRIC_NAME, VALUE, TIMESTAMP, UNIT, REGION, ACCESS_KEY, SECRET_KEY,
    +                            CREDENTIALS_FILE, AWS_CREDENTIALS_PROVIDER_SERVICE, TIMEOUT, SSL_CONTEXT_SERVICE,
    +                            ENDPOINT_OVERRIDE, PROXY_HOST, PROXY_HOST_PORT)
    +            );
    +
    +    @Override
    +    protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
    +        return properties;
    +    }
    +
    +    @Override
    +    public Set<Relationship> getRelationships() {
    +        return relationships;
    +    }
    +
    +    /**
    +     * Create client using aws credentials provider. This is the preferred way for creating clients
    +     */
    +
    +    @Override
    +    protected AmazonCloudWatchClient createClient(ProcessContext processContext, AWSCredentialsProvider awsCredentialsProvider, ClientConfiguration clientConfiguration) {
    +        getLogger().info("Creating client using aws credentials provider");
    +        return new AmazonCloudWatchClient(awsCredentialsProvider, clientConfiguration);
    +    }
    +
    +    /**
    +     * Create client using AWSCredentials
    +     *
    +     * @deprecated use {@link #createClient(ProcessContext, AWSCredentialsProvider, ClientConfiguration)} instead
    +     */
    +    @Override
    +    protected AmazonCloudWatchClient createClient(ProcessContext processContext, AWSCredentials awsCredentials, ClientConfiguration clientConfiguration) {
    +        getLogger().debug("Creating client with aws credentials");
    +        return new AmazonCloudWatchClient(awsCredentials, clientConfiguration);
    +    }
    +
    +
    +    @Override
    +    public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
    +        FlowFile flowFile = session.get();
    +        if (flowFile == null) {
    +            return;
    +        }
    +
    +        final AmazonCloudWatchClient client = getClient();
    +
    +        MetricDatum dataum = new MetricDatum();
    --- End diff --
    
    Should this be `datum` instead of `dataum`?  Admittedly not my most insightful review comment, I'm just trying to prove I'm paying attention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by vegaed <gi...@git.apache.org>.
Github user vegaed commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1125#discussion_r83200380
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java ---
    @@ -0,0 +1,203 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.aws.cloudwatch;
    +
    +import com.amazonaws.ClientConfiguration;
    +import com.amazonaws.auth.AWSCredentials;
    +import com.amazonaws.auth.AWSCredentialsProvider;
    +import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
    +import com.amazonaws.services.cloudwatch.model.MetricDatum;
    +import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
    +import org.apache.nifi.annotation.behavior.SupportsBatching;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
    +
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +
    +@SupportsBatching
    +@InputRequirement(Requirement.INPUT_REQUIRED)
    +@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
    +@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
    +public class PutCloudWatchMetric extends AbstractAWSCredentialsProviderProcessor<AmazonCloudWatchClient> {
    +
    +    public static final Set<Relationship> relationships = Collections.unmodifiableSet(
    +            new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
    +
    +    private static final Validator DOUBLE_VALIDATOR = new Validator() {
    +        @Override
    +        public ValidationResult validate(String subject, String input, ValidationContext context) {
    +            if (context.isExpressionLanguageSupported(subject) && context.isExpressionLanguagePresent(input)) {
    +                return (new ValidationResult.Builder()).subject(subject).input(input).explanation("Expression Language Present").valid(true).build();
    +            } else {
    +                String reason = null;
    +
    +                try {
    +                    Double.parseDouble(input);
    +                } catch (NumberFormatException var6) {
    +                    reason = "not a valid Double";
    +                }
    +
    +                return (new ValidationResult.Builder()).subject(subject).input(input).explanation(reason).valid(reason == null).build();
    +            }
    +        }
    +    };
    +
    +    public static final PropertyDescriptor NAMESPACE = new PropertyDescriptor.Builder()
    +            .name("Namespace")
    +            .displayName("Namespace")
    +            .description("The namespace for the metric data for CloudWatch")
    +            .required(true)
    +            .expressionLanguageSupported(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor METRIC_NAME = new PropertyDescriptor.Builder()
    +            .name("MetricName")
    +            .displayName("MetricName")
    +            .description("The name of the metric")
    +            .expressionLanguageSupported(true)
    +            .required(true)
    +            .addValidator(new StandardValidators.StringLengthValidator(1, 255))
    +            .build();
    +
    +    public static final PropertyDescriptor VALUE = new PropertyDescriptor.Builder()
    +            .name("Value")
    +            .displayName("Value")
    +            .description("The value for the metric. Must be a double")
    +            .expressionLanguageSupported(true)
    +            .required(true)
    +            .addValidator(DOUBLE_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor TIMESTAMP = new PropertyDescriptor.Builder()
    +            .name("Timestamp")
    +            .displayName("Timestamp")
    +            .description("A point in time expressed as the number of milliseconds since Jan 1, 1970 00:00:00 UTC. If not specified, the default value is set to the time the metric data was received")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.LONG_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor UNIT = new PropertyDescriptor.Builder()
    +            .name("Unit")
    +            .displayName("Unit")
    +            .description("The unit of the metric. (e.g Seconds, Bytes, Megabytes, Percent, Count,  Kilobytes/Second, Terabits/Second, Count/Second) For details see http://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final List<PropertyDescriptor> properties =
    +            Collections.unmodifiableList(
    +                    Arrays.asList(NAMESPACE, METRIC_NAME, VALUE, TIMESTAMP, UNIT, REGION, ACCESS_KEY, SECRET_KEY,
    +                            CREDENTIALS_FILE, AWS_CREDENTIALS_PROVIDER_SERVICE, TIMEOUT, SSL_CONTEXT_SERVICE,
    +                            ENDPOINT_OVERRIDE, PROXY_HOST, PROXY_HOST_PORT)
    +            );
    +
    +    @Override
    +    protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
    +        return properties;
    +    }
    +
    +    @Override
    +    public Set<Relationship> getRelationships() {
    +        return relationships;
    +    }
    +
    +    /**
    +     * Create client using aws credentials provider. This is the preferred way for creating clients
    +     */
    +
    +    @Override
    +    protected AmazonCloudWatchClient createClient(ProcessContext processContext, AWSCredentialsProvider awsCredentialsProvider, ClientConfiguration clientConfiguration) {
    +        getLogger().info("Creating client using aws credentials provider");
    +        return new AmazonCloudWatchClient(awsCredentialsProvider, clientConfiguration);
    +    }
    +
    +    /**
    +     * Create client using AWSCredentials
    +     *
    +     * @deprecated use {@link #createClient(ProcessContext, AWSCredentialsProvider, ClientConfiguration)} instead
    +     */
    +    @Override
    +    protected AmazonCloudWatchClient createClient(ProcessContext processContext, AWSCredentials awsCredentials, ClientConfiguration clientConfiguration) {
    +        getLogger().debug("Creating client with aws credentials");
    +        return new AmazonCloudWatchClient(awsCredentials, clientConfiguration);
    +    }
    +
    +
    +    @Override
    +    public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
    +        FlowFile flowFile = session.get();
    +        if (flowFile == null) {
    +            return;
    +        }
    +
    +        final AmazonCloudWatchClient client = getClient();
    +
    +        MetricDatum dataum = new MetricDatum();
    --- End diff --
    
    Yes it should


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by vegaed <gi...@git.apache.org>.
Github user vegaed commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    So I guess it ready to be merged then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1125#discussion_r83091812
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java ---
    @@ -0,0 +1,203 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.aws.cloudwatch;
    +
    +import com.amazonaws.ClientConfiguration;
    +import com.amazonaws.auth.AWSCredentials;
    +import com.amazonaws.auth.AWSCredentialsProvider;
    +import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
    +import com.amazonaws.services.cloudwatch.model.MetricDatum;
    +import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
    +import org.apache.nifi.annotation.behavior.SupportsBatching;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
    +
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +
    +@SupportsBatching
    +@InputRequirement(Requirement.INPUT_REQUIRED)
    +@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
    +@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
    +public class PutCloudWatchMetric extends AbstractAWSCredentialsProviderProcessor<AmazonCloudWatchClient> {
    +
    +    public static final Set<Relationship> relationships = Collections.unmodifiableSet(
    +            new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
    +
    +    private static final Validator DOUBLE_VALIDATOR = new Validator() {
    +        @Override
    +        public ValidationResult validate(String subject, String input, ValidationContext context) {
    +            if (context.isExpressionLanguageSupported(subject) && context.isExpressionLanguagePresent(input)) {
    +                return (new ValidationResult.Builder()).subject(subject).input(input).explanation("Expression Language Present").valid(true).build();
    +            } else {
    +                String reason = null;
    +
    +                try {
    +                    Double.parseDouble(input);
    +                } catch (NumberFormatException var6) {
    --- End diff --
    
    Any significance to `var6`?  How about `nfe` or just `e`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    Thanks, @vegaed, this is definitely going to improve my flow monitoring.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @vegaed I don't think you should worry, I do not believe the Appveyor build is stable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @vegaed Thanks for the updated code.  The situation with AbstractAWSProcessor is a bit odd.  It's deprecated in that you should not derive directly from it, but it still has live code we're definitely using.
    
    * **Number Parsing Exception Handling** - I tested with a non-double metric value.  A java.lang.NumberFormatException is thrown parsing the number at PutCloudWatchMetric.java:174.  The error message is clear enough, but the exception is not caught inside onTrigger(), so the entire session is rolled back and the flowfile remains in the incoming queue.  The same thing applies to parsing Timestamp.  Shouldn't we catch the exception and route the flowfile to failure in a case like this?
    * **Integration Tests** - Integration tests failed for me, complaining about no flowfiles routed to REL_SUCCESS.  I believe the fix might be as simple as adding an empty flowfile before running:
    
            runner.enqueue(new byte[] {});
            runner.run();
    
    * **Unit Tests** - How about some unit tests that do not call AWS?  I agree there is no substitute for integration tests that actually call AWS, but I believe there is also no substitute for unit tests that can easily be run by anyone and everyone.  This can be a bit tricky for cloud services, but it seems like CloudWatch has an API with nice request/response patterns that can be mocked.  So I tried my hand at a [simple mock setup with sample tests for PutCloudWatchMetric](https://github.com/jvwing/nifi/commit/b6ae1accfecb464fe16a456cdef04669a65672fe).  You're welcome to not use this, but I recommend we try something similar that gets coverage of onTrigger from unit tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by vegaed <gi...@git.apache.org>.
Github user vegaed commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @jvwing Thanks for all the great suggestions and code. 
    
    I moved the try up in order to catch those types of parsing exceptions so now they will route to failure.
    
    Good catch on the integration tests
    
    Yes I agree unit testing is good. I was modeling off of S3 and SQS and didn't see any there, but I see now that dynamo and kinesis packages are being both unit and integration tested.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1125
  
    @vegaed thanks for putting this together.  I have a few initial suggestions from a quick scan:
    
    * Please run `mvn clean install -Pcontrib-check` - there are a few issues with .* imports, unused imports, etc.
    * Did you forget to incude an entry for PutCloudWatchMetric processor in the service definition file org.apache.nifi.processor.Processor?
    * For PropertyDescriptors, please provide both `name` (as a data key) and `displayName` (for UI presentation)
    * Why not use REL_SUCCESS and REL_FAILURE inherited from AbstractAWSProcessor?  The descriptions would be less specific, but it appears to be a standard practice.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---