You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/07 01:21:53 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #7089: [AIRFLOW-6452]
scheduler_job.py - remove excess sleep/log/duration calls
tooptoop4 opened a new pull request #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #7089: [AIRFLOW-6452]
scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f782bd2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `92.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
========================================
Coverage ? 84.8%
========================================
Files ? 680
Lines ? 38802
Branches ? 0
========================================
Hits ? 32905
Misses ? 5897
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.96% <ø> (ø)` | |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `100% <ø> (ø)` | |
| [...irflow/contrib/operators/emr\_add\_steps\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lbXJfYWRkX3N0ZXBzX29wZXJhdG9yLnB5) | `91.42% <ø> (ø)` | |
| [...ib/operators/azure\_container\_instances\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzX29wZXJhdG9yLnB5) | `78.14% <ø> (ø)` | |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <ø> (ø)` | |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `91.4% <100%> (ø)` | |
| [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <100%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [f782bd2...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f782bd2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `92.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
========================================
Coverage ? 84.8%
========================================
Files ? 680
Lines ? 38802
Branches ? 0
========================================
Hits ? 32905
Misses ? 5897
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.96% <ø> (ø)` | |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `100% <ø> (ø)` | |
| [...irflow/contrib/operators/emr\_add\_steps\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lbXJfYWRkX3N0ZXBzX29wZXJhdG9yLnB5) | `91.42% <ø> (ø)` | |
| [...ib/operators/azure\_container\_instances\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzX29wZXJhdG9yLnB5) | `78.14% <ø> (ø)` | |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <ø> (ø)` | |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `91.4% <100%> (ø)` | |
| [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <100%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [f782bd2...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration
calls
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#discussion_r363738078
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1539,7 +1538,6 @@ def _execute_helper(self):
# For the execute duration, parse and schedule DAGs
while True:
- self.log.debug("Starting Loop...")
Review comment:
Why do you remove the debug logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f782bd2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `92.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
========================================
Coverage ? 84.8%
========================================
Files ? 680
Lines ? 38802
Branches ? 0
========================================
Hits ? 32905
Misses ? 5897
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.96% <ø> (ø)` | |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `100% <ø> (ø)` | |
| [...irflow/contrib/operators/emr\_add\_steps\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lbXJfYWRkX3N0ZXBzX29wZXJhdG9yLnB5) | `91.42% <ø> (ø)` | |
| [...ib/operators/azure\_container\_instances\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzX29wZXJhdG9yLnB5) | `78.14% <ø> (ø)` | |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <ø> (ø)` | |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `91.4% <100%> (ø)` | |
| [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <100%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [f782bd2...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#discussion_r363784723
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1539,7 +1538,6 @@ def _execute_helper(self):
# For the execute duration, parse and schedule DAGs
while True:
- self.log.debug("Starting Loop...")
Review comment:
they slow it down, 'starting loop' on while true: seems meaningless
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #7089: [AIRFLOW-6452]
scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571391385
before this PR it had 2 sleeps (no need!), it seems the one I removed was there before the processor_poll_interval sleep was added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f782bd2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `92.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
========================================
Coverage ? 84.8%
========================================
Files ? 680
Lines ? 38802
Branches ? 0
========================================
Hits ? 32905
Misses ? 5897
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.96% <ø> (ø)` | |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `100% <ø> (ø)` | |
| [...irflow/contrib/operators/emr\_add\_steps\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lbXJfYWRkX3N0ZXBzX29wZXJhdG9yLnB5) | `91.42% <ø> (ø)` | |
| [...ib/operators/azure\_container\_instances\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzX29wZXJhdG9yLnB5) | `78.14% <ø> (ø)` | |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <ø> (ø)` | |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `91.4% <100%> (ø)` | |
| [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <100%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [f782bd2...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7089:
[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7089: [AIRFLOW-6452]
scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-571536434
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=h1) Report
> Merging [#7089](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf3c4b34f77f11164c12813c911f86871f761da0?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7089/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7089 +/- ##
=========================================
- Coverage 85.07% 84.8% -0.28%
=========================================
Files 680 680
Lines 38810 38802 -8
=========================================
- Hits 33019 32905 -114
- Misses 5791 5897 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <ø> (+0.45%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7089/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=footer). Last update [cf3c4b3...1273612](https://codecov.io/gh/apache/airflow/pull/7089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #7089: [AIRFLOW-6452]
scheduler_job.py - remove excess sleep/log/duration calls
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-572280616
@nuclearpinguin pls merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services