You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/12/01 14:03:24 UTC
[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1426
[FLINK-3093] Introduce annotations for interface stability
With this pull request, I'm introducing annotations for marking the stability of certain Flink interfaces.
The annotations are in the `flink-annotations` module. I needed to create a new module because the maven plugin I'm intending to use needs to have access to the annotations at runtime.
My first idea was to add them to `flink-core`, but that lead to circular dependencies.
Speaking of maven plugins: I did not yet include the infrastructure to enforce interface stability. I'm currently trying to find a maven plugin which will allow us to automatically verify the stability.
The problem is that the plugin needs some additional features until we can use it. But I hope we get it in place with the 1.0.0 release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink interface_stability_no_maven
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1426
----
commit 7c23d762aabafdb2ed46aaafd306d474751624ff
Author: Robert Metzger <rm...@apache.org>
Date: 2015-11-10T19:46:07Z
[FLINK-3093] Introduce annotations for interface stability
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161045370
Hi @rmetzger, thanks for taking the initiative for this issue!
I tried to review the PR, but the diff set it too large for the Github viewer. I know, I could checkout the code and do the diffs on my machine, but I hope I am not the only one reviewing the changes.
Would you mind splitting up the PR into a let's say four smaller ones for Core, DataSet, DataStream, and Connectors (any other reasonable split is fine with me as well)?
That would really ease reviewing the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161056518
Okay, I'll reopen two new PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---