You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/28 10:11:41 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #5517: Fix #3448 quota calculation for monthly tariffs

DaanHoogland commented on pull request #5517:
URL: https://github.com/apache/cloudstack/pull/5517#issuecomment-929049561


   Your code looks alright @jairov4 but only if the aggregation is always hourly. I think there is another problem with the code and that is that the onehour vars are not named correctly; `BigDecimal onehourcostpercpu, onehourcostper100mhz, onehourcostper1mb, onehourcostforvmusage;`. I think these should have been called 'oneaggregation*'.
   Have you tested with other agrregation durations?
   Care to comment @abhinandanprateek , @rhtyd , @rafaelweingartner ? (not sure who else to ask)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org