[GitHub] spark pull request #17076: [SPARK-19745][ML] SVCAggregator captures coeffici...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17076#discussion_r103764323
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
    @@ -463,6 +458,8 @@ private class LinearSVCAggregator(
        */
       def add(instance: Instance): this.type = {
         instance match { case Instance(label, weight, features) =>
    +      require(numFeatures == features.size, s"Dimensions mismatch when adding new instance." +
    --- End diff --
    
    So we are moving the dimension check here yes? Seems better than at [L446](https://github.com/apache/spark/pull/17076/files#diff-0d3dbd8bcb54f614839418d64680593aL446) in fact


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org