You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2016/04/19 19:11:55 UTC
Review Request 46390: OOZIE-2509- SLA job status can stuck in running
state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs
-----
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java, line 69
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350693#file1350693line69>
> >
> > Why 0? Why not leave it at default?
>
> Purshotam Shah wrote:
> SLAThread working on slaMap will also call this. If it's waits for 5sec for each job, it will take more time. If lock is held it will process in next run on another server.
If a job status notification is not processed, then job will not be updated by periodic check till end time is reached. For eg: if job finishes 20 mins before endtime, sla status will remain in running till periodic check verifies it after 20 mins. You can have 0L for periodic checks. But need a longer lock timeout for job status checks.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 231
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line231>
> >
> > Why change WAITING to FAILED? Need a test case for waiting.
>
> Purshotam Shah wrote:
> CoordinatorActionBean action1 = addRecordToCoordActionTable("coord-action-C@1", 1,
> CoordinatorAction.Status.FAILED, "coord-action-get.xml", 0);
> WorkflowJobBean extWf = new WorkflowJobBean();
> extWf.setId(action1.getExternalId());
> extWf.setEndTime(new Date(System.currentTimeMillis() - 1 * 1800 * 1000));
> extWf.setStartTime(new Date(System.currentTimeMillis() - 1 * 2100 * 1000));
>
>
> Testcase were wrong, bcz it was marked as waiting, but it has WF and wf has endtime. Since WF has ended, job should be in terminal state.
Can we remove the workflow database entry instead? There is already a FAILED case, but no other testcase for waiting state. FAILED will take the isTerminalWithFailure codepath.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129630
-----------------------------------------------------------
On April 20, 2016, 5:13 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java, line 69
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350693#file1350693line69>
> >
> > Why 0? Why not leave it at default?
SLAThread working on slaMap will also call this. If it's waits for 5sec for each job, it will take more time. If lock is held it will process in next run on another server.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java, line 472
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350702#file1350702line472>
> >
> > Should be MISS as duration is missed
>From doc
https://oozie.apache.org/docs/4.0.0/DG_SLAMonitoring.html
>>Met <-- caused by an END_MET
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 231
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line231>
> >
> > Why change WAITING to FAILED? Need a test case for waiting.
CoordinatorActionBean action1 = addRecordToCoordActionTable("coord-action-C@1", 1,
CoordinatorAction.Status.FAILED, "coord-action-get.xml", 0);
WorkflowJobBean extWf = new WorkflowJobBean();
extWf.setId(action1.getExternalId());
extWf.setEndTime(new Date(System.currentTimeMillis() - 1 * 1800 * 1000));
extWf.setStartTime(new Date(System.currentTimeMillis() - 1 * 2100 * 1000));
Testcase were wrong, bcz it was marked as waiting, but it has WF and wf has endtime. Since WF has ended, job should be in terminal state.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 192
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line192>
> >
> > Why remove this?
There were two consecutive addStatusEvent call, since we are confirming with DB. It doesn't matter. I added it back.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java, line 107
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350704#file1350704line107>
> >
> > Why set expected end and change to end_miss? We need a test for start_miss
It's old job, job end time < current time. Added test for end_miss.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129630
-----------------------------------------------------------
On April 19, 2016, 8:54 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java, line 63
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350691#file1350691line63>
> >
> > updateSLAInformation
Sorry. It updates job information and not sla. Should be updateJobInfo
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129630
-----------------------------------------------------------
On April 19, 2016, 8:54 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 231
> > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line231>
> >
> > Why change WAITING to FAILED? Need a test case for waiting.
>
> Purshotam Shah wrote:
> CoordinatorActionBean action1 = addRecordToCoordActionTable("coord-action-C@1", 1,
> CoordinatorAction.Status.FAILED, "coord-action-get.xml", 0);
> WorkflowJobBean extWf = new WorkflowJobBean();
> extWf.setId(action1.getExternalId());
> extWf.setEndTime(new Date(System.currentTimeMillis() - 1 * 1800 * 1000));
> extWf.setStartTime(new Date(System.currentTimeMillis() - 1 * 2100 * 1000));
>
>
> Testcase were wrong, bcz it was marked as waiting, but it has WF and wf has endtime. Since WF has ended, job should be in terminal state.
>
> Rohini Palaniswamy wrote:
> Can we remove the workflow database entry instead? There is already a FAILED case, but no other testcase for waiting state. FAILED will take the isTerminalWithFailure codepath.
added testcase for waiting.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129630
-----------------------------------------------------------
On April 20, 2016, 5:13 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129630
-----------------------------------------------------------
Please update https://issues.apache.org/jira/browse/OOZIE-2509 with some details on the issue and its cause and summary of changes in the patch. Anyone other than me cannot get any context about the issue or what the patch does.
First pass - Review for just test case changes. Still going through code refactor.
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java (line 48)
<https://reviews.apache.org/r/46390/#comment193065>
Use CoordActionQueryExecutor with GET_COORD_ACTION. We also have to change to load only required fields. Create a new jira for that.
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java (line 63)
<https://reviews.apache.org/r/46390/#comment193066>
updateSLAInformation
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 41)
<https://reviews.apache.org/r/46390/#comment193071>
isReQueueRequired should be implemented and return false
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 42)
<https://reviews.apache.org/r/46390/#comment193074>
Remove and use *QueryExecutor classes
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 69)
<https://reviews.apache.org/r/46390/#comment193070>
Why 0? Why not leave it at default?
core/src/test/java/org/apache/oozie/service/TestHASLAService.java (lines 361 - 364)
<https://reviews.apache.org/r/46390/#comment193072>
Remove dead code
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java (line 471)
<https://reviews.apache.org/r/46390/#comment193073>
Should be MISS as duration is missed
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java (line 703)
<https://reviews.apache.org/r/46390/#comment193076>
Whitespaces will become -1 in pre-commit build. Present in other classes as well
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java (line 886)
<https://reviews.apache.org/r/46390/#comment193078>
Please just use static String constants for RUNNING and SUCCEEDED statuses instead of doing toString() on enum everytime.
Also better practice to use name() instead of toString() with enums.
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java (line 107)
<https://reviews.apache.org/r/46390/#comment193080>
Why set expected end and change to end_miss? We need a test for start_miss
core/src/test/java/org/apache/oozie/sla/TestSLAService.java
<https://reviews.apache.org/r/46390/#comment193083>
Why remove this?
core/src/test/java/org/apache/oozie/sla/TestSLAService.java (line 229)
<https://reviews.apache.org/r/46390/#comment193086>
Why change WAITING to FAILED? Need a test case for waiting.
- Rohini Palaniswamy
On April 19, 2016, 8:54 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 20, 2016, midnight, Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java, line 50
> > <https://reviews.apache.org/r/46390/diff/3/?file=1351727#file1351727line50>
> >
> > Can we avoid leaking slaMap and historySet into the command classes? It is not a good programming practice.
Thanks. I thought of removing it after the initial patch but forgot.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129638
-----------------------------------------------------------
On April 20, 2016, 5:13 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129638
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java (lines 59 - 61)
<https://reviews.apache.org/r/46390/#comment193129>
Move to SLAJobEventXCommand
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java (line 63)
<https://reviews.apache.org/r/46390/#comment193142>
updateJobInfo
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java (lines 55 - 56)
<https://reviews.apache.org/r/46390/#comment193146>
Should throw exception
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 50)
<https://reviews.apache.org/r/46390/#comment193112>
Can we avoid leaking slaMap and historySet into the command classes? It is not a good programming practice.
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 94)
<https://reviews.apache.org/r/46390/#comment193151>
Not required. Being logged again in SLACalculatorMemory
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java (line 150)
<https://reviews.apache.org/r/46390/#comment193132>
Return state from these classes and use that to perform update operations the maps in SLACalculatorMemory. Do not update them here.
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java (line 93)
<https://reviews.apache.org/r/46390/#comment193144>
the x exception - Comment is meaningless. Please remove that in all places.
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java (line 95)
<https://reviews.apache.org/r/46390/#comment193143>
updateSLASummary
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 127)
<https://reviews.apache.org/r/46390/#comment193153>
LOG.warn
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 131)
<https://reviews.apache.org/r/46390/#comment193116>
Failed to fetch the job (remove workflow)
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 147)
<https://reviews.apache.org/r/46390/#comment193120>
adding -> Adding
getEventProcessed -> EventProcessed
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/46390/#comment193122>
If this is removed, history set will not be updated for end time and start time until 1 day (when HistoryPurgeWorker runs) if job completion event happened when this server went down or was going down.
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 223)
<https://reviews.apache.org/r/46390/#comment193123>
Remove double spaces in sentence
" Starting updateJobSla for job -> "Starting updateJobSla for job
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 241)
<https://reviews.apache.org/r/46390/#comment193124>
job has SLA event change
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 472)
<https://reviews.apache.org/r/46390/#comment193128>
Method always returns true which is not correct
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java (lines 56 - 57)
<https://reviews.apache.org/r/46390/#comment193114>
Formatting - Should be in braces
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java (lines 81 - 82)
<https://reviews.apache.org/r/46390/#comment193113>
Formatting - Should be in braces
This patch adds too much logging. Please review and cut down on logging.
- Rohini Palaniswamy
On April 19, 2016, 8:54 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129779
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 96)
<https://reviews.apache.org/r/46390/#comment193336>
You can set initial delay to 0. Also change default interval to 1 hr instead of 1 day. 1 day is too long.
- Rohini Palaniswamy
On April 20, 2016, 5:13 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 22, 2016, 10:42 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/service/TestHASLAService.java, line 205
> > <https://reviews.apache.org/r/46390/diff/6-7/?file=1353673#file1353673line205>
> >
> > How does setting eventProcessed to 1 go to history set?
Because end date is set.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review130200
-----------------------------------------------------------
On April 22, 2016, 10:09 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 10:09 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review130200
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java (line 199)
<https://reviews.apache.org/r/46390/#comment193921>
Why is this required to be public?
core/src/test/java/org/apache/oozie/service/TestHASLAService.java (line 205)
<https://reviews.apache.org/r/46390/#comment193910>
How does setting eventProcessed to 1 go to history set?
core/src/test/java/org/apache/oozie/service/TestHASLAService.java (line 215)
<https://reviews.apache.org/r/46390/#comment193902>
Comment is cryptic. Either remove or make it meaningful
core/src/test/java/org/apache/oozie/service/TestHASLAService.java (line 217)
<https://reviews.apache.org/r/46390/#comment193905>
Space after comma
core/src/test/java/org/apache/oozie/service/TestHASLAService.java (line 234)
<https://reviews.apache.org/r/46390/#comment193906>
Space after comma
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java (line 484)
<https://reviews.apache.org/r/46390/#comment193922>
add asserts for status as well.
- Rohini Palaniswamy
On April 22, 2016, 10:09 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 10:09 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review133381
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On May 13, 2016, 6:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 6:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 666316254575dd26498182d43a53196289f8a843
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java ef1ea982b21738d88470b49650980efdf437aa43
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated May 13, 2016, 6:23 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 666316254575dd26498182d43a53196289f8a843
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java ef1ea982b21738d88470b49650980efdf437aa43
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 29, 2016, 7:49 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 666316254575dd26498182d43a53196289f8a843
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java ef1ea982b21738d88470b49650980efdf437aa43
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 22, 2016, 10:09 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 5914b3b0e9230983a60625864853fd2790e10945
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129789
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 20, 2016, 7:53 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 7:53 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 20, 2016, 7:53 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5c0cfd9779e4a04d6d9533dd018c9b17ccd5bab4
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 20, 2016, 7:40 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 4246764d9aa7666f38c6f66de2b2075934a587dc
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/#review129768
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/46390/#comment193322>
Can you retain this comment which tells the kind of scenario being tested
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java (line 171)
<https://reviews.apache.org/r/46390/#comment193310>
Need last modified time as well. Remove this and reuse GET_COORD_ACTION_FOR_SLA
- Rohini Palaniswamy
On April 20, 2016, 5:13 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46390/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2509
> https://issues.apache.org/jira/browse/OOZIE-2509
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> SLA job status can stuck in running state
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
> core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
> core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
> core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
>
> Diff: https://reviews.apache.org/r/46390/diff/
>
>
> Testing
> -------
>
> Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
>
> $ git status | grep delete
> deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
> deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 20, 2016, 5:13 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0
core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 128feb21993156fd33798fb9178ef926c0e832cc
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 79ec28cac6a6b0d874239904fca61cac756eab35
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 078fd404993d96b7fd62215a617b4cac6cfbf455
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java ce108d56f4cf6e124cd99be2e28cc1cea764077e
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java 52560e67fdec2e8671d17a2e7cf21633156505e6
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing (updated)
-------
Removed unused jpa class. Somehow it's not part of patch. Will remove them while committing.
$ git status | grep delete
deleted: src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java
deleted: src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java
$
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 19, 2016, 8:54 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 46390: OOZIE-2509- SLA job status can stuck in
running state
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46390/
-----------------------------------------------------------
(Updated April 19, 2016, 7:37 p.m.)
Review request for oozie.
Bugs: OOZIE-2509
https://issues.apache.org/jira/browse/OOZIE-2509
Repository: oozie-git
Description
-------
SLA job status can stuck in running state
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd3ab804c527afc115402295916b29f63d2
core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37316d6ced825618f6976133691c02bd940
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 432efef6989951b0d66405dd3762cbfe2c965556
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c28cf035e528e7d024f254205d6c52d3309
core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f77552f26aba962dddc63e3158d007b07a4
core/src/test/java/org/apache/oozie/sla/TestSLAService.java c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf
Diff: https://reviews.apache.org/r/46390/diff/
Testing
-------
Thanks,
Purshotam Shah