You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/01 15:47:56 UTC
[GitHub] [ignite] timoninmaxim opened a new pull request #9463: IGNITE-15522 IndexQuery runs index scan if no criteria set
timoninmaxim opened a new pull request #9463:
URL: https://github.com/apache/ignite/pull/9463
In case criteria aren't specified for IndexQuery, it runs index scan by index. If index name isn't specified it gets PK index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9463: IGNITE-15522 IndexQuery runs index scan if no criteria set
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9463:
URL: https://github.com/apache/ignite/pull/9463#discussion_r729001324
##########
File path: modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryWrongIndexTest.java
##########
@@ -37,14 +39,23 @@
private static final String DESC_ID_IDX = "DESC_ID_IDX";
/** */
- @Test
- public void testWrongIndexAndFieldsMatching() throws Exception {
+ private static IgniteCache<Integer, Person> cache;
+
+ /** {@inheritDoc} */
+ @Override protected void beforeTestsStarted() throws Exception {
+ super.beforeTestsStarted();
+
Ignite crd = startGrids(2);
- IgniteCache<Integer, Person> cache = crd.getOrCreateCache(new CacheConfiguration<Integer, Person>()
+ cache = crd.getOrCreateCache(new CacheConfiguration<Integer, Person>()
+ .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)
Review comment:
TRANSACTIONAL mode looks redundant here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #9463: IGNITE-15522 IndexQuery runs index scan if no criteria set
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #9463:
URL: https://github.com/apache/ignite/pull/9463#discussion_r729032142
##########
File path: modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryWrongIndexTest.java
##########
@@ -37,14 +39,23 @@
private static final String DESC_ID_IDX = "DESC_ID_IDX";
/** */
- @Test
- public void testWrongIndexAndFieldsMatching() throws Exception {
+ private static IgniteCache<Integer, Person> cache;
+
+ /** {@inheritDoc} */
+ @Override protected void beforeTestsStarted() throws Exception {
+ super.beforeTestsStarted();
+
Ignite crd = startGrids(2);
- IgniteCache<Integer, Person> cache = crd.getOrCreateCache(new CacheConfiguration<Integer, Person>()
+ cache = crd.getOrCreateCache(new CacheConfiguration<Integer, Person>()
+ .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)
Review comment:
This is done because Atomic doesn't guarantee index updates. I've create a ticket for investigating that [1]. Otherwise this test will be flaky on TC.
[1] https://issues.apache.org/jira/browse/IGNITE-15671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org