You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org> on 2021/05/28 09:23:00 UTC

[jira] [Resolved] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

     [ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Tzvetanov Grigorov resolved WICKET-6890.
-----------------------------------------------
    Fix Version/s: 10.0.0
       Resolution: Fixed

> Render debug setting 'outputMarkupContainerClassName` as an attribute
> ---------------------------------------------------------------------
>
>                 Key: WICKET-6890
>                 URL: https://issues.apache.org/jira/browse/WICKET-6890
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>             Fix For: 10.0.0
>
>
> As discussed at [https://markmail.org/message/uoxxlnbz56ex7vuk] when org.apache.wicket.settings.DebugSettings#isOutputMarkupContainerClassName() returns true then the MarkupContainer class name should be rendered as an attribute of the component tag instead of as an HTML comment because an HTML comment may break a CSS rule, e.g. by appearing between two sibling HTML elements
> {code:java}
> p + p {color: red;} {code}
>  
> The CSS rule above will change the text color of any paragraph that follows another paragraph. But if an HTML comment appears between them then the rule won't apply.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)