You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ja...@apache.org on 2018/02/16 12:57:21 UTC
[cordova-windows] 03/03: remove unused param from method
getBuildTargets
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-win10only
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
commit 6236b859978a9b4d2f909b0bcf110b53ef7ff1a0
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Fri Feb 16 13:57:02 2018 +0100
remove unused param from method getBuildTargets
---
template/cordova/lib/build.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/template/cordova/lib/build.js b/template/cordova/lib/build.js
index 37ead69..d7f8744 100644
--- a/template/cordova/lib/build.js
+++ b/template/cordova/lib/build.js
@@ -54,7 +54,7 @@ module.exports.run = function run (buildOptions) {
var buildConfig = parseAndValidateArgs(buildOptions);
// get build targets
- var selectedBuildTargets = getBuildTargets(buildConfig.win, buildConfig.phone, buildConfig);
+ var selectedBuildTargets = getBuildTargets(buildConfig.win, buildConfig.phone);
return MSBuildTools.getLatestMatchingMSBuild(selectedBuildTargets) // get latest msbuild tools
.then(function (result) {
@@ -81,8 +81,7 @@ module.exports.run = function run (buildOptions) {
};
// returns list of projects to be built based on config.xml and additional parameters
-function getBuildTargets (isWinSwitch, isPhoneSwitch, buildConfig) {
- buildConfig = typeof buildConfig !== 'undefined' ? buildConfig : null;
+function getBuildTargets (isWinSwitch, isPhoneSwitch) {
// TODO This whole method can be super simplified as there is only one target
--
To stop receiving notification emails like this one, please contact
janpio@apache.org.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org