[jira] [Commented] (FLINK-12502) Harden JobMasterTest#testRequestNextInputSplitWithDataSourceFailover

["Gary Yao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847383#comment-16847383 ] 

Gary Yao commented on FLINK-12502:
----------------------------------

Are you working on this [~xleesf]?

> Harden JobMasterTest#testRequestNextInputSplitWithDataSourceFailover
> --------------------------------------------------------------------
>
>                 Key: FLINK-12502
>                 URL: https://issues.apache.org/jira/browse/FLINK-12502
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination, Tests
>    Affects Versions: 1.9.0
>            Reporter: Till Rohrmann
>            Assignee: leesf
>            Priority: Major
>
> The {{JobMasterTest#testRequestNextInputSplitWithDataSourceFailover}} relies on how many files you have in your working directory. This assumption is quite brittle. Instead we should explicitly instantiate an {{InputSplitAssigner}} with a defined number of input splits. 
> Moreover, we should make the assertions more explicit: Input split comparisons should not rely solely on the length of the input split data.
> Maybe it is also not necessary to capture the full {{TaskDeploymentDescriptor}} because we could already know the producer's and consumer's {{JobVertexID}} when we create the {{JobGraph}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)