You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Henry Saputra <he...@gmail.com> on 2015/11/06 22:21:09 UTC
Question on how and should the Scala code change from => to ⇒ symbol?
Hi Mahout devs,
I am looking at the Mahout Scala code and some parts of the code use ⇒
symbol and some use =>.
I know we can use sacalriform to format the Scala code in sbt, but I
am not sure it is done with maven?
And also should we use ⇒ to represent => in Scala code for patches and
contributions?
Thanks,
- Henry
Re: Question on how and should the Scala code change from => to ⇒ symbol?
Posted by Henry Saputra <he...@gmail.com>.
Cool, thanks for the info :)
On Friday, November 6, 2015, Dmitriy Lyubimov <dl...@gmail.com> wrote:
> like i said, only if i happened to make a substantial change to a file.
>
> On Fri, Nov 6, 2015 at 3:10 PM, Dmitriy Lyubimov <dlieu.7@gmail.com
> <javascript:;>> wrote:
>
> > find-and-replace in idea :)
> >
> > On Fri, Nov 6, 2015 at 2:40 PM, Henry Saputra <henry.saputra@gmail.com
> <javascript:;>>
> > wrote:
> >
> >> Hi Dmitriy,
> >>
> >> Thanks for the reply. So were you doing it manually or did you use
> >> tools to convert it as part of commit or build flow?
> >>
> >> - Henry
> >>
> >> On Fri, Nov 6, 2015 at 2:08 PM, Dmitriy Lyubimov <dlieu.7@gmail.com
> <javascript:;>>
> >> wrote:
> >> > We, well, I was trying to migrate to the unicode one. Perhaps a bit
> >> > unilaterally, simply because that's how I have been writing the rest
> of
> >> my
> >> > code for the past couple years. But of course I did that on occasional
> >> > basis. The rule I was following was on the file uniformity basis. If I
> >> > replace one instance in a file, I replace all the rest. So no mixed
> >> style
> >> > in a file.
> >> > On Nov 6, 2015 1:21 PM, "Henry Saputra" <henry.saputra@gmail.com
> <javascript:;>>
> >> wrote:
> >> >
> >> >> Hi Mahout devs,
> >> >>
> >> >> I am looking at the Mahout Scala code and some parts of the code use
> ⇒
> >> >> symbol and some use =>.
> >> >>
> >> >> I know we can use sacalriform to format the Scala code in sbt, but I
> >> >> am not sure it is done with maven?
> >> >> And also should we use ⇒ to represent => in Scala code for patches
> and
> >> >> contributions?
> >> >>
> >> >>
> >> >> Thanks,
> >> >>
> >> >>
> >> >> - Henry
> >> >>
> >>
> >
> >
>
Re: Question on how and should the Scala code change from => to ⇒ symbol?
Posted by Dmitriy Lyubimov <dl...@gmail.com>.
like i said, only if i happened to make a substantial change to a file.
On Fri, Nov 6, 2015 at 3:10 PM, Dmitriy Lyubimov <dl...@gmail.com> wrote:
> find-and-replace in idea :)
>
> On Fri, Nov 6, 2015 at 2:40 PM, Henry Saputra <he...@gmail.com>
> wrote:
>
>> Hi Dmitriy,
>>
>> Thanks for the reply. So were you doing it manually or did you use
>> tools to convert it as part of commit or build flow?
>>
>> - Henry
>>
>> On Fri, Nov 6, 2015 at 2:08 PM, Dmitriy Lyubimov <dl...@gmail.com>
>> wrote:
>> > We, well, I was trying to migrate to the unicode one. Perhaps a bit
>> > unilaterally, simply because that's how I have been writing the rest of
>> my
>> > code for the past couple years. But of course I did that on occasional
>> > basis. The rule I was following was on the file uniformity basis. If I
>> > replace one instance in a file, I replace all the rest. So no mixed
>> style
>> > in a file.
>> > On Nov 6, 2015 1:21 PM, "Henry Saputra" <he...@gmail.com>
>> wrote:
>> >
>> >> Hi Mahout devs,
>> >>
>> >> I am looking at the Mahout Scala code and some parts of the code use ⇒
>> >> symbol and some use =>.
>> >>
>> >> I know we can use sacalriform to format the Scala code in sbt, but I
>> >> am not sure it is done with maven?
>> >> And also should we use ⇒ to represent => in Scala code for patches and
>> >> contributions?
>> >>
>> >>
>> >> Thanks,
>> >>
>> >>
>> >> - Henry
>> >>
>>
>
>
Re: Question on how and should the Scala code change from => to ⇒ symbol?
Posted by Dmitriy Lyubimov <dl...@gmail.com>.
find-and-replace in idea :)
On Fri, Nov 6, 2015 at 2:40 PM, Henry Saputra <he...@gmail.com>
wrote:
> Hi Dmitriy,
>
> Thanks for the reply. So were you doing it manually or did you use
> tools to convert it as part of commit or build flow?
>
> - Henry
>
> On Fri, Nov 6, 2015 at 2:08 PM, Dmitriy Lyubimov <dl...@gmail.com>
> wrote:
> > We, well, I was trying to migrate to the unicode one. Perhaps a bit
> > unilaterally, simply because that's how I have been writing the rest of
> my
> > code for the past couple years. But of course I did that on occasional
> > basis. The rule I was following was on the file uniformity basis. If I
> > replace one instance in a file, I replace all the rest. So no mixed style
> > in a file.
> > On Nov 6, 2015 1:21 PM, "Henry Saputra" <he...@gmail.com> wrote:
> >
> >> Hi Mahout devs,
> >>
> >> I am looking at the Mahout Scala code and some parts of the code use ⇒
> >> symbol and some use =>.
> >>
> >> I know we can use sacalriform to format the Scala code in sbt, but I
> >> am not sure it is done with maven?
> >> And also should we use ⇒ to represent => in Scala code for patches and
> >> contributions?
> >>
> >>
> >> Thanks,
> >>
> >>
> >> - Henry
> >>
>
Re: Question on how and should the Scala code change from => to ⇒ symbol?
Posted by Henry Saputra <he...@gmail.com>.
Hi Dmitriy,
Thanks for the reply. So were you doing it manually or did you use
tools to convert it as part of commit or build flow?
- Henry
On Fri, Nov 6, 2015 at 2:08 PM, Dmitriy Lyubimov <dl...@gmail.com> wrote:
> We, well, I was trying to migrate to the unicode one. Perhaps a bit
> unilaterally, simply because that's how I have been writing the rest of my
> code for the past couple years. But of course I did that on occasional
> basis. The rule I was following was on the file uniformity basis. If I
> replace one instance in a file, I replace all the rest. So no mixed style
> in a file.
> On Nov 6, 2015 1:21 PM, "Henry Saputra" <he...@gmail.com> wrote:
>
>> Hi Mahout devs,
>>
>> I am looking at the Mahout Scala code and some parts of the code use ⇒
>> symbol and some use =>.
>>
>> I know we can use sacalriform to format the Scala code in sbt, but I
>> am not sure it is done with maven?
>> And also should we use ⇒ to represent => in Scala code for patches and
>> contributions?
>>
>>
>> Thanks,
>>
>>
>> - Henry
>>
Re: Question on how and should the Scala code change from => to ⇒ symbol?
Posted by Dmitriy Lyubimov <dl...@gmail.com>.
We, well, I was trying to migrate to the unicode one. Perhaps a bit
unilaterally, simply because that's how I have been writing the rest of my
code for the past couple years. But of course I did that on occasional
basis. The rule I was following was on the file uniformity basis. If I
replace one instance in a file, I replace all the rest. So no mixed style
in a file.
On Nov 6, 2015 1:21 PM, "Henry Saputra" <he...@gmail.com> wrote:
> Hi Mahout devs,
>
> I am looking at the Mahout Scala code and some parts of the code use ⇒
> symbol and some use =>.
>
> I know we can use sacalriform to format the Scala code in sbt, but I
> am not sure it is done with maven?
> And also should we use ⇒ to represent => in Scala code for patches and
> contributions?
>
>
> Thanks,
>
>
> - Henry
>