You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/11 07:15:43 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10107: MINOR: Improve confusing admin client shutdown logging

chia7712 commented on a change in pull request #10107:
URL: https://github.com/apache/kafka/pull/10107#discussion_r574286504



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -756,6 +756,11 @@ protected Node curNode() {
             return curNode;
         }
 
+        void abortAndFail(Throwable throwable) {

Review comment:
       How about changing the input type from `Throwable` to `TimeoutException`? The exception passed to this method should NOT be wrapped by `TimeoutException`. Using explicit type (`TimeoutException`) can prevent us from passing incorrect exception in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org