[jira] [Commented] (FELIX-4848) Split ResolverImpl

["Christian Schneider (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564417#comment-14564417 ] 

Christian Schneider commented on FELIX-4848:
--------------------------------------------

[~rickhall] Hi Richard. As most of the code in ResolverImpl is from you I suggest you decide about this patch. If you do not intend to apply it I suggest we close this issue. I do not like having jira issues dangling around for too long. Especially refactoring patches typically are not applicable after some time anyway.
If you change your mind at any time I am willing to create a new issue and patch.


> Split ResolverImpl
> ------------------
>
>                 Key: FELIX-4848
>                 URL: https://issues.apache.org/jira/browse/FELIX-4848
>             Project: Felix
>          Issue Type: Improvement
>          Components: Resolver
>    Affects Versions: resolver-1.0.0
>            Reporter: Christian Schneider
>             Fix For: resolver-1.4.0
>
>         Attachments: Dependencies in resolver package after patch.png, FELIX-4848-1.patch
>
>
> ResolverImpl currently contains about 2300 lines of code. That is way too big for a single class.
> I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.
> Both would share all of the inner classes of ResolverImpl but nothing else. 
> So I think i would make sense to move these inner classes to separate files.
> These changes should nicely split the classes into 
> ResolverImpl : 1400 lines
> ConsistencyCheck : 600 lines



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)