[GitHub] sijie commented on issue #928: Changes to shading bookkeeper-server jar

[GitBox <gi...@apache.org>]

sijie commented on issue #928: Changes to shading bookkeeper-server jar
URL: https://github.com/apache/bookkeeper/pull/928#issuecomment-354430211
 
 
   Also a few other things to call out
   
   1) currently I keep two options open. a shaded artifact on `bookkeeper-server` and a separate artifact `bookkeeper-server-shaded`. If it is going to confuse users, I am open to remove one.
   
   2) `shadeTestJar` can also produce a shaded artifact over the tests jar of `bookkeeper-server`. however shade plugin doesn't install/deploy the shaded tests jar to mvn repository. so if a project wanna to use a shaded bookkeeper-server jar, but actually it can't use the tests jar of bookkeeper-server. the `bookkeeper-server-tests-shaded` is the shaded tests jar of `bookkeeper-server-shaded`, so when `bookkeeper-server-shaded` is used, the corresponding tests jar can be used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services