You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jo...@apache.org on 2011/06/28 15:54:37 UTC
svn commit: r1140621 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services:
ComponentMethodInvocation.java ComponentValueProvider.java
Author: joshcanfield
Date: Tue Jun 28 13:54:36 2011
New Revision: 1140621
URL: http://svn.apache.org/viewvc?rev=1140621&view=rev
Log:
TAP5-1559 - Excessive warnings
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java?rev=1140621&r1=1140620&r2=1140621&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java Tue Jun 28 13:54:36 2011
@@ -15,10 +15,6 @@
package org.apache.tapestry5.services;
import org.apache.tapestry5.ioc.Invocation;
-import org.apache.tapestry5.plastic.MethodAdvice;
-import org.apache.tapestry5.plastic.MethodInvocation;
-import org.apache.tapestry5.plastic.PlasticClass;
-import org.apache.tapestry5.plastic.PlasticMethod;
import org.apache.tapestry5.runtime.Component;
import org.apache.tapestry5.runtime.ComponentResourcesAware;
@@ -28,8 +24,12 @@ import org.apache.tapestry5.runtime.Comp
* the {@link org.apache.tapestry5.ComponentResources} of the component for which a method is being advised.
*
* @deprecated Deprecated in 5.3
- * @see {@link PlasticClass}, {@link PlasticMethod}, {@link MethodAdvice}, {@link MethodInvocation}
+ * @see org.apache.tapestry5.plastic.PlasticClass
+ * @see org.apache.tapestry5.plastic.PlasticMethod
+ * @see org.apache.tapestry5.plastic.MethodAdvice
+ * @see org.apache.tapestry5.plastic.MethodInvocation
*/
+@SuppressWarnings({"deprecation"})
public interface ComponentMethodInvocation extends Invocation, ComponentResourcesAware
{
/**
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java?rev=1140621&r1=1140620&r2=1140621&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java Tue Jun 28 13:54:36 2011
@@ -15,8 +15,6 @@
package org.apache.tapestry5.services;
import org.apache.tapestry5.ComponentResources;
-import org.apache.tapestry5.plastic.ComputedValue;
-import org.apache.tapestry5.plastic.PlasticField;
/**
* An object used to provide a value of a specific type to a component (represented by an
@@ -28,8 +26,10 @@ import org.apache.tapestry5.plastic.Plas
* type of object provided
* @since 5.2.0
* @deprecated Deprecated in 5.3.0, using Plastic equivalents
- * @see {@link PlasticField}, {@link ComputedValue}
+ * @see org.apache.tapestry5.plastic.PlasticField
+ * @see org.apache.tapestry5.plastic.ComputedValue
*/
+@SuppressWarnings("deprecation")
public interface ComponentValueProvider<T>
{
/**
Re: svn commit: r1140621 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services:
ComponentMethodInvocation.java ComponentValueProvider.java
Posted by Josh Canfield <jo...@gmail.com>.
I'm only suppressing the warnings that a deprecated class is using
deprecated code.
On Jun 29, 2011 2:11 AM, "Ulrich Stärk" <ul...@spielviel.de> wrote:
> Why are you suppressing deprecation warnings? Shouldn't these rather be
fixed? At least keep the
> warnings so that developers are aware of an issue.
>
> Uli
>
> On 28.06.2011 15:54, joshcanfield@apache.org wrote:
>> Author: joshcanfield
>> Date: Tue Jun 28 13:54:36 2011
>> New Revision: 1140621
>>
>> URL: http://svn.apache.org/viewvc?rev=1140621&view=rev
>> Log:
>> TAP5-1559 - Excessive warnings
>>
>> Modified:
>>
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
>>
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
>>
>> Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
>> URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java?rev=1140621&r1=1140620&r2=1140621&view=diff
>>
==============================================================================
>> ---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
(original)
>> +++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
Tue Jun 28 13:54:36 2011
>> @@ -15,10 +15,6 @@
>> package org.apache.tapestry5.services;
>>
>> import org.apache.tapestry5.ioc.Invocation;
>> -import org.apache.tapestry5.plastic.MethodAdvice;
>> -import org.apache.tapestry5.plastic.MethodInvocation;
>> -import org.apache.tapestry5.plastic.PlasticClass;
>> -import org.apache.tapestry5.plastic.PlasticMethod;
>> import org.apache.tapestry5.runtime.Component;
>> import org.apache.tapestry5.runtime.ComponentResourcesAware;
>>
>> @@ -28,8 +24,12 @@ import org.apache.tapestry5.runtime.Comp
>> * the {@link org.apache.tapestry5.ComponentResources} of the component
for which a method is being advised.
>> *
>> * @deprecated Deprecated in 5.3
>> - * @see {@link PlasticClass}, {@link PlasticMethod}, {@link
MethodAdvice}, {@link MethodInvocation}
>> + * @see org.apache.tapestry5.plastic.PlasticClass
>> + * @see org.apache.tapestry5.plastic.PlasticMethod
>> + * @see org.apache.tapestry5.plastic.MethodAdvice
>> + * @see org.apache.tapestry5.plastic.MethodInvocation
>> */
>> +@SuppressWarnings({"deprecation"})
>> public interface ComponentMethodInvocation extends Invocation,
ComponentResourcesAware
>> {
>> /**
>>
>> Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
>> URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java?rev=1140621&r1=1140620&r2=1140621&view=diff
>>
==============================================================================
>> ---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
(original)
>> +++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
Tue Jun 28 13:54:36 2011
>> @@ -15,8 +15,6 @@
>> package org.apache.tapestry5.services;
>>
>> import org.apache.tapestry5.ComponentResources;
>> -import org.apache.tapestry5.plastic.ComputedValue;
>> -import org.apache.tapestry5.plastic.PlasticField;
>>
>> /**
>> * An object used to provide a value of a specific type to a component
(represented by an
>> @@ -28,8 +26,10 @@ import org.apache.tapestry5.plastic.Plas
>> * type of object provided
>> * @since 5.2.0
>> * @deprecated Deprecated in 5.3.0, using Plastic equivalents
>> - * @see {@link PlasticField}, {@link ComputedValue}
>> + * @see org.apache.tapestry5.plastic.PlasticField
>> + * @see org.apache.tapestry5.plastic.ComputedValue
>> */
>> +@SuppressWarnings("deprecation")
>> public interface ComponentValueProvider<T>
>> {
>> /**
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
Re: svn commit: r1140621 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services:
ComponentMethodInvocation.java ComponentValueProvider.java
Posted by Ulrich Stärk <ul...@spielviel.de>.
Why are you suppressing deprecation warnings? Shouldn't these rather be fixed? At least keep the
warnings so that developers are aware of an issue.
Uli
On 28.06.2011 15:54, joshcanfield@apache.org wrote:
> Author: joshcanfield
> Date: Tue Jun 28 13:54:36 2011
> New Revision: 1140621
>
> URL: http://svn.apache.org/viewvc?rev=1140621&view=rev
> Log:
> TAP5-1559 - Excessive warnings
>
> Modified:
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java?rev=1140621&r1=1140620&r2=1140621&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodInvocation.java Tue Jun 28 13:54:36 2011
> @@ -15,10 +15,6 @@
> package org.apache.tapestry5.services;
>
> import org.apache.tapestry5.ioc.Invocation;
> -import org.apache.tapestry5.plastic.MethodAdvice;
> -import org.apache.tapestry5.plastic.MethodInvocation;
> -import org.apache.tapestry5.plastic.PlasticClass;
> -import org.apache.tapestry5.plastic.PlasticMethod;
> import org.apache.tapestry5.runtime.Component;
> import org.apache.tapestry5.runtime.ComponentResourcesAware;
>
> @@ -28,8 +24,12 @@ import org.apache.tapestry5.runtime.Comp
> * the {@link org.apache.tapestry5.ComponentResources} of the component for which a method is being advised.
> *
> * @deprecated Deprecated in 5.3
> - * @see {@link PlasticClass}, {@link PlasticMethod}, {@link MethodAdvice}, {@link MethodInvocation}
> + * @see org.apache.tapestry5.plastic.PlasticClass
> + * @see org.apache.tapestry5.plastic.PlasticMethod
> + * @see org.apache.tapestry5.plastic.MethodAdvice
> + * @see org.apache.tapestry5.plastic.MethodInvocation
> */
> +@SuppressWarnings({"deprecation"})
> public interface ComponentMethodInvocation extends Invocation, ComponentResourcesAware
> {
> /**
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java?rev=1140621&r1=1140620&r2=1140621&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentValueProvider.java Tue Jun 28 13:54:36 2011
> @@ -15,8 +15,6 @@
> package org.apache.tapestry5.services;
>
> import org.apache.tapestry5.ComponentResources;
> -import org.apache.tapestry5.plastic.ComputedValue;
> -import org.apache.tapestry5.plastic.PlasticField;
>
> /**
> * An object used to provide a value of a specific type to a component (represented by an
> @@ -28,8 +26,10 @@ import org.apache.tapestry5.plastic.Plas
> * type of object provided
> * @since 5.2.0
> * @deprecated Deprecated in 5.3.0, using Plastic equivalents
> - * @see {@link PlasticField}, {@link ComputedValue}
> + * @see org.apache.tapestry5.plastic.PlasticField
> + * @see org.apache.tapestry5.plastic.ComputedValue
> */
> +@SuppressWarnings("deprecation")
> public interface ComponentValueProvider<T>
> {
> /**
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org