You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/25 04:33:21 UTC

[PR] fix(message): reject negative queue coordinates [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2561:
URL: https://github.com/apache/rocketmq-dashboard/pull/2561

   ## Summary
   
   - reject negative queue IDs before the queue browser invokes its provider
   - reject negative queue offsets at the same service boundary
   - verify invalid coordinates never reach the message provider
   
   ## Why
   
   A queue ID and physical queue offset cannot be negative. Passing those values through to the RocketMQ client turned invalid user input into downstream provider errors instead of a stable client-facing 400 response.
   
   ## Validation
   
   - `mvn -Dtest=MessageServiceTest test`
   - Maven Checkstyle (0 violations)
   - `git diff --check`
   
   Closes #2557.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(message): reject negative queue coordinates [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2561:
URL: https://github.com/apache/rocketmq-dashboard/pull/2561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org