You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/02/11 22:52:00 UTC
[jira] [Commented] (TAP5-2651) TypeCoercer should favor exact match
coercions over intermediate ones
[ https://issues.apache.org/jira/browse/TAP5-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283423#comment-17283423 ]
ASF subversion and git services commented on TAP5-2651:
-------------------------------------------------------
Commit 6dcc25e533cd79b9d0bfc91b8002de488d6baf89 in tapestry-5's branch refs/heads/5.6.x from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=6dcc25e ]
TAP5-2651: TypeCoercer favoring exact match coercions
over indirect/intermediate ones
# Conflicts:
# commons/src/main/java/org/apache/tapestry5/ioc/internal/services/TypeCoercerImpl.java
> TypeCoercer should favor exact match coercions over intermediate ones
> ---------------------------------------------------------------------
>
> Key: TAP5-2651
> URL: https://issues.apache.org/jira/browse/TAP5-2651
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
> Reporter: Thiago Henrique De Paula Figueiredo
> Assignee: Thiago Henrique De Paula Figueiredo
> Priority: Major
> Fix For: 5.6.2, 5.7.0
>
>
> While checking why the TAP5-2645 patch had a [failing test|https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/47/testReport/ioc.specs/TypeCoercerSpec/coerce_java_lang_Integer_2020_to_java_time_Year_should_be_2020/], I noticed I was wrong about an assumption I made about TypeCoercer: it doesn't favor exact match coercions (i.e. coercions with the exact same source and target classes) over other ones, leaving the possibility of an intermediate (i.e. non-direct) one to be picked up even when an exact match one exists.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)