You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/03/04 17:08:14 UTC
[GitHub] [daffodil] mbeckerle commented on a change in pull request #495: Patterns to match strings with newlines.
mbeckerle commented on a change in pull request #495:
URL: https://github.com/apache/daffodil/pull/495#discussion_r587654901
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Facets.scala
##########
@@ -160,7 +162,7 @@ trait Facets { self: Restriction =>
// The XSD numeric character entity  can be used to match ASCII NUL
// (char code 0).
//
- val remapped = XMLUtils.remapPUAToXMLIllegalCharacters(v)
+ val remapped: String = XMLUtils.remapPUAToXMLIllegalCharacters(v)
Review comment:
Yes, I needed these in order to figure out what was going on here. Type aliases were confusing IDEA. I tend to leave in that sort of thing when it's needed to improve understanding, why take it back out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org