You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 11:33:07 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28051: [WIP][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
MaxGekk opened a new pull request #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605118178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120487/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605468216
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#discussion_r399654289
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -198,8 +209,19 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
*
* You can set the following option(s):
* <ul>
- * <li>`timeZone` (default session local timezone): sets the string that indicates a timezone
- * to be used to format timestamps in the JSON/CSV datasources or partition values.</li>
+ * <li>`timeZone` (default session local timezone): sets the string that indicates a time zone ID
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605468216
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605467972
**[Test build #120529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120529/testReport)** for PR 28051 at commit [`99ccc58`](https://github.com/apache/spark/commit/99ccc589ef9650f817ac2d06ab13aa1ffabff9a8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605118163
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605773684
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28051: [WIP][SQL][DOC] Specify
formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953149
**[Test build #120487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120487/testReport)** for PR 28051 at commit [`2ad2972`](https://github.com/apache/spark/commit/2ad2972387ea26b9c3d8a315a292ca7573f33dd9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and
from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953556
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605468222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120529/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437666
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605468222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120529/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605118163
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28051: [SPARK-31286][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604954868
@HyukjinKwon @cloud-fan Please, have a look at the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437508
**[Test build #120529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120529/testReport)** for PR 28051 at commit [`99ccc58`](https://github.com/apache/spark/commit/99ccc589ef9650f817ac2d06ab13aa1ffabff9a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605118178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120487/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25235/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#discussion_r399229670
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -198,8 +209,19 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
*
* You can set the following option(s):
* <ul>
- * <li>`timeZone` (default session local timezone): sets the string that indicates a timezone
- * to be used to format timestamps in the JSON/CSV datasources or partition values.</li>
+ * <li>`timeZone` (default session local timezone): sets the string that indicates a time zone ID
Review comment:
ah got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953149
**[Test build #120487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120487/testReport)** for PR 28051 at commit [`2ad2972`](https://github.com/apache/spark/commit/2ad2972387ea26b9c3d8a315a292ca7573f33dd9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437508
**[Test build #120529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120529/testReport)** for PR 28051 at commit [`99ccc58`](https://github.com/apache/spark/commit/99ccc589ef9650f817ac2d06ab13aa1ffabff9a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#discussion_r399229854
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -198,8 +209,19 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
*
* You can set the following option(s):
* <ul>
- * <li>`timeZone` (default session local timezone): sets the string that indicates a timezone
- * to be used to format timestamps in the JSON/CSV datasources or partition values.</li>
+ * <li>`timeZone` (default session local timezone): sets the string that indicates a time zone ID
Review comment:
shall we update the comment? It's not for parsing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051: [WIP][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25192/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28051: [WIP][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953556
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#discussion_r399223589
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -198,8 +209,19 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
*
* You can set the following option(s):
* <ul>
- * <li>`timeZone` (default session local timezone): sets the string that indicates a timezone
- * to be used to format timestamps in the JSON/CSV datasources or partition values.</li>
+ * <li>`timeZone` (default session local timezone): sets the string that indicates a time zone ID
Review comment:
If a pattern contains sub-pattern for time zone like `V` or `z`, which one formatter should output?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC]
Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605117132
**[Test build #120487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120487/testReport)** for PR 28051 at commit [`2ad2972`](https://github.com/apache/spark/commit/2ad2972387ea26b9c3d8a315a292ca7573f33dd9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437666
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#discussion_r399208963
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -198,8 +209,19 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
*
* You can set the following option(s):
* <ul>
- * <li>`timeZone` (default session local timezone): sets the string that indicates a timezone
- * to be used to format timestamps in the JSON/CSV datasources or partition values.</li>
+ * <li>`timeZone` (default session local timezone): sets the string that indicates a time zone ID
Review comment:
is the `timezone` option effective for writing? AFAIK it's for parsing only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and
from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [WIP][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-604953564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25192/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28051:
[SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option
and from/to_utc_timestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28051: [SPARK-31286][SQL][DOC] Specify formats of time zone ID for JSON/CSV option and from/to_utc_timestamp
URL: https://github.com/apache/spark/pull/28051#issuecomment-605437669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25235/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org