You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/06/16 12:32:13 UTC

Review Request 35505: SQOOP-2103: Not able define Decimal(n, p) data type in map-column-hive option

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35505/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2103
    https://issues.apache.org/jira/browse/SQOOP-2103


Repository: sqoop-trunk


Description
-------

commit fe7944bd54907b6a741cc5398f18682eb2b59e21
Author: Abraham Elmahrek <ab...@apache.org>
Date:   Mon Jun 15 20:22:34 2015 +0300

    SQOOP-2103: Not able define Decimal(n,p) data type in map-column-hive option

:100644 100644 ef6e0ce... d7c9cbb... M  src/java/org/apache/sqoop/SqoopOptions.java
:000000 100644 0000000... 0ce3619... A  src/test/org/apache/sqoop/TestSqoopOptions.java


Diffs
-----

  src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce 
  src/test/org/apache/sqoop/TestSqoopOptions.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35505/diff/


Testing
-------

Added a test case


Thanks,

Abraham Elmahrek


Re: Review Request 35505: SQOOP-2103: Not able define Decimal(n, p) data type in map-column-hive option

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35505/
-----------------------------------------------------------

(Updated June 25, 2015, 2:44 a.m.)


Review request for Sqoop.


Bugs: SQOOP-2103
    https://issues.apache.org/jira/browse/SQOOP-2103


Repository: sqoop-trunk


Description
-------

commit fe7944bd54907b6a741cc5398f18682eb2b59e21
Author: Abraham Elmahrek <ab...@apache.org>
Date:   Mon Jun 15 20:22:34 2015 +0300

    SQOOP-2103: Not able define Decimal(n,p) data type in map-column-hive option

:100644 100644 ef6e0ce... d7c9cbb... M  src/java/org/apache/sqoop/SqoopOptions.java
:000000 100644 0000000... 0ce3619... A  src/test/org/apache/sqoop/TestSqoopOptions.java


Diffs (updated)
-----

  src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce 
  src/test/org/apache/sqoop/TestSqoopOptions.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35505/diff/


Testing
-------

Added a test case


Thanks,

Abraham Elmahrek


Re: Review Request 35505: SQOOP-2103: Not able define Decimal(n, p) data type in map-column-hive option

Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35505/#review88197
-----------------------------------------------------------

Ship it!


Ship It!

- Qian Xu


On June 16, 2015, 6:32 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35505/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 6:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2103
>     https://issues.apache.org/jira/browse/SQOOP-2103
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> commit fe7944bd54907b6a741cc5398f18682eb2b59e21
> Author: Abraham Elmahrek <ab...@apache.org>
> Date:   Mon Jun 15 20:22:34 2015 +0300
> 
>     SQOOP-2103: Not able define Decimal(n,p) data type in map-column-hive option
> 
> :100644 100644 ef6e0ce... d7c9cbb... M  src/java/org/apache/sqoop/SqoopOptions.java
> :000000 100644 0000000... 0ce3619... A  src/test/org/apache/sqoop/TestSqoopOptions.java
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce 
>   src/test/org/apache/sqoop/TestSqoopOptions.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35505/diff/
> 
> 
> Testing
> -------
> 
> Added a test case
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>