[GitHub] [incubator-superset] betodealmeida opened a new pull request #8233: Simplify and improve `expand_data` in Presto

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #8233: Simplify and improve `expand_data` in Presto
URL: https://github.com/apache/incubator-superset/pull/8233
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR simplifies the logic of the `expand_data` method in Presto, while making it more generic. Queries that were failing before, like
   
   ```sql
   SELECT ARRAY[ROW(100,0,'hello')]
   ```
   
   are now working.
   
   Some of the methods in `db_engine_specs/presto.py` are no longer used and can be removed; I'll do that in a subsequent PR. I wanted to keep this PR simple and small because it's blocking an important release.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I updated the unit tests, and tested with real data. I'll add more unit tests in the next PR, covering more complex cases.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org