You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "tm_jee (JIRA)" <ji...@apache.org> on 2006/11/15 17:03:57 UTC
[jira] Created: (WW-1506) Sitemesh plugin's struts-plugin.xml uses
incorrect filter for both freemarker and velocity
Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
------------------------------------------------------------------------------------------
Key: WW-1506
URL: http://issues.apache.org/struts/browse/WW-1506
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.0.1
Reporter: tm_jee
Assigned To: tm_jee
Fix For: 2.0.2
Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
<struts>
<bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
<bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
</struts>
should be
<struts>
<bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
<bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
</struts>
By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38705 ]
tm_jee commented on WW-1506:
----------------------------
changes to sitemesh-plugin.
Sending src/main/resources/struts-plugin.xml
Transmitting file data .
Committed revision 475283.
changes to struts-core
Sending src/main/java/org/apache/struts2/config/BeanSelectionProvider.java
Sending src/main/java/org/apache/struts2/config/ClasspathConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/LegacyPropertiesConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/StrutsXmlConfigurationProvider.java
Sending src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
Sending src/test/java/org/apache/struts2/TestConfigurationProvider.java
Sending src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java
Transmitting file data .......
Committed revision 475284.
changes to xwork2
Sending src/java/com/opensymphony/xwork2/config/ConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
Sending src/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerBuilder.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerImpl.java
Sending src/test/com/opensymphony/xwork2/ActionNestingTest.java
Sending src/test/com/opensymphony/xwork2/config/providers/MockConfigurationProvider.java
Sending src/test/com/opensymphony/xwork2/interceptor/PreResultListenerTest.java
Transmitting file data ........
Committed revision 1196.
Please kindly review the code. Leaving this issue open until its being reviewed. Thanks
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38722 ]
tm_jee commented on WW-1506:
----------------------------
I see. cool.
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: Don Brown
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1506) Sitemesh plugin's struts-plugin.xml uses
incorrect filter for both freemarker and velocity
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=all ]
Don Brown resolved WW-1506.
---------------------------
Resolution: Fixed
Assignee: Don Brown
Fixed. The key was to determine why the dependencies, VelocityManager in this case, were being loaded at all since they would throw a no class def error as soon as they were touched. The solution was to call the getDeclaredConstructors() method on them before they are loaded into the container, which forces the error to be thrown. Then, it was a matter of handling the case in the bean selector when a defined extension point wasn't there. Oh, and the sitemesh plugin had to have the manager dependencies declared optional, then be made to complain loudly when used but without their dependencies set.
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: Don Brown
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38712 ]
tm_jee commented on WW-1506:
----------------------------
I've go ahead and reverted back the changes.
They are at
xwork2
Sending src/java/com/opensymphony/xwork2/config/ConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
Sending src/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerBuilder.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerImpl.java
Sending src/test/com/opensymphony/xwork2/ActionNestingTest.java
Sending src/test/com/opensymphony/xwork2/config/providers/MockConfigurationProvider.java
Sending src/test/com/opensymphony/xwork2/interceptor/PreResultListenerTest.java
Transmitting file data ........
Committed revision 1197.
sturs2-core
Sending src/main/java/org/apache/struts2/config/BeanSelectionProvider.java
Sending src/main/java/org/apache/struts2/config/ClasspathConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/LegacyPropertiesConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/StrutsXmlConfigurationProvider.java
Sending src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
Sending src/test/java/org/apache/struts2/TestConfigurationProvider.java
Sending src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java
Transmitting file data .......
Committed revision 475508.
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38710 ]
tm_jee commented on WW-1506:
----------------------------
Just as an followup for those who didn't subscibe to the mailing list. Don advised that we'd like to minimize change on the DI Container, and a workaround might be to inject in FreeMarkerPageFilter and VelocityPageFilter using
@Inject(required=false)
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38711 ]
tm_jee commented on WW-1506:
----------------------------
Just reverted the changes back on my local machine and tried out with
@Inject(required=false) on both FreeMarkerPageFilter and VelocityPageFilter. Got the following trace when trying to start up jetty using mvn jetty:run
2006-11-15 19:22:43,901 INFO [StrutsSpringObjectFactory.java:94] : ... initialized Struts-Spring integration successfully
2006-11-15 19:22:43.935::WARN: failed action2-cleanup
2006-11-15 19:22:43.935::WARN: failed ContextHandler@1474e45{/myApp,file:/home/tmjee/development/temp/myApp/src/main/webapp/}
2006-11-15 19:22:43.935::WARN: failed ContextHandlerCollection@63a721
2006-11-15 19:22:43.935::WARN: failed HandlerCollection@719f1f
2006-11-15 19:22:44.162::INFO: Started SelectChannelConnector @ 0.0.0.0:8080
2006-11-15 19:22:44.163::WARN: failed Server@166340c
[INFO] Jetty server exiting.
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] org/apache/velocity/context/Context
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.NoClassDefFoundError: org/apache/velocity/context/Context
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2328)
at java.lang.Class.getDeclaredConstructors(Class.java:1808)
at com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector.findConstructorIn(ContainerImpl.java:313)
at com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector.<init>(ContainerImpl.java:291)
at com.opensymphony.xwork2.inject.ContainerImpl$5.create(ContainerImpl.java:277)
at com.opensymphony.xwork2.inject.ContainerImpl$5.create(ContainerImpl.java:276)
at com.opensymphony.xwork2.inject.util.ReferenceCache$CallableCreate.call(ReferenceCache.java:155)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
at java.util.concurrent.FutureTask.run(FutureTask.java:123)
at com.opensymphony.xwork2.inject.util.ReferenceCache.internalCreate(ReferenceCache.java:81)
at com.opensymphony.xwork2.inject.util.ReferenceCache.get(ReferenceCache.java:121)
at com.opensymphony.xwork2.inject.ContainerImpl.getConstructor(ContainerImpl.java:534)
at com.opensymphony.xwork2.inject.ContainerBuilder$5.create(ContainerBuilder.java:207)
at com.opensymphony.xwork2.inject.Scope$2$1.create(Scope.java:49)
at com.opensymphony.xwork2.inject.ContainerImpl$ParameterInjector.inject(ContainerImpl.java:407)
at com.opensymphony.xwork2.inject.ContainerImpl.getParameters(ContainerImpl.java:422)
at com.opensymphony.xwork2.inject.ContainerImpl.access$000(ContainerImpl.java:42)
at com.opensymphony.xwork2.inject.ContainerImpl$MethodInjector.inject(ContainerImpl.java:266)
at com.opensymphony.xwork2.inject.ContainerImpl$2.call(ContainerImpl.java:95)
at com.opensymphony.xwork2.inject.ContainerImpl$2.call(ContainerImpl.java:93)
at com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:514)
at com.opensymphony.xwork2.inject.ContainerImpl.injectStatics(ContainerImpl.java:92)
at com.opensymphony.xwork2.inject.ContainerBuilder.create(ContainerBuilder.java:494)
at com.opensymphony.xwork2.config.impl.DefaultConfiguration.reload(DefaultConfiguration.java:139)
at com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:52)
at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:339)
at org.apache.struts2.dispatcher.Dispatcher.<init>(Dispatcher.java:198)
at org.apache.struts2.dispatcher.AbstractFilter.createDispatcher(AbstractFilter.java:153)
at org.apache.struts2.dispatcher.AbstractFilter.init(AbstractFilter.java:111)
at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:95)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:545)
at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1133)
at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:420)
at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:457)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
at org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:120)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:119)
at org.mortbay.jetty.Server.doStart(Server.java:210)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
at org.mortbay.jetty.plugin.Jetty6PluginServer.start(Jetty6PluginServer.java:134)
at org.mortbay.jetty.plugin.AbstractJettyMojo.startJetty(AbstractJettyMojo.java:327)
at org.mortbay.jetty.plugin.AbstractJettyMojo.execute(AbstractJettyMojo.java:272)
at org.mortbay.jetty.plugin.AbstractJettyRunMojo.execute(AbstractJettyRunMojo.java:177)
at org.mortbay.jetty.plugin.Jetty6RunMojo.execute(Jetty6RunMojo.java:183)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:273)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11 seconds
[INFO] Finished at: Wed Nov 15 19:22:44 EST 2006
[INFO] Final Memory: 6M/12M
[INFO] ------------------------------------------------------------------------
2006-11-15 19:22:44.590::INFO: Shutdown hook executing
2006-11-15 19:22:44.590::INFO: Shutdown hook complete
tmjee@tmjee-laptop:~/development/temp/myApp$
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WW-1506) Sitemesh plugin's struts-plugin.xml uses
incorrect filter for both freemarker and velocity
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1506?page=all ]
tm_jee reassigned WW-1506:
--------------------------
Assignee: (was: tm_jee)
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira