You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Radu Coravu (JIRA)" <xe...@xml.apache.org> on 2010/10/14 11:29:33 UTC

[jira] Commented: (XERCESJ-1205) Entity resolution does not work with DTD grammar caching resolved

    [ https://issues.apache.org/jira/browse/XERCESJ-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920898#action_12920898 ] 

Radu Coravu commented on XERCESJ-1205:
--------------------------------------

Just one small rectification to what Thomas added as a patch:
In the method XMLEntityManager.initFromDTD

the current code is:
..............
 if(entityDecl.publicId != null {
                try {
                    addExternalEntity(entityDecl.name, entityDecl.publicId, entityDecl.systemId, entityDecl.baseSystemId);
                }
.................................

it should be something like:
..........................
if(entityDecl.publicId != null
                || entityDecl.systemId != null) {
                try {
                    addExternalEntity(entityDecl.name, entityDecl.publicId, entityDecl.systemId, entityDecl.baseSystemId);
                }
................................

In this way external SYSTEM entities will also be preserved.

> Entity resolution does not work with DTD grammar caching resolved
> -----------------------------------------------------------------
>
>                 Key: XERCESJ-1205
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1205
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: DTD
>    Affects Versions: 2.8.1
>         Environment: JDK1.5. The issue appears on various machines, Windows, Linux, Mac OSX. I don't believe it is platform specific.
>            Reporter: Tin Pavlinic
>            Assignee: Michael Glavassevich
>         Attachments: bug.zip, XERCESJ-1465.patch
>
>
> We have a DTD which defines some entities. We are parsing multiple documents against this DTD. If grammar caching is enabled, the entities are unresolved when the grammar is loaded from the cache, instead of the DTD. 
> It seems that they are cleared every time a document is parsed and are only loaded when a DTD is loaded and not from the cache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org