[jira] [Commented] (YARN-2361) remove duplicate entries (EXPIRE event) in the EnumSet of event type in RMAppAttempt state machine

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075200#comment-14075200 ] 

Hadoop QA commented on YARN-2361:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12657941/YARN-2361.000.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4442//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4442//console

This message is automatically generated.

> remove duplicate entries (EXPIRE event) in the EnumSet of event type in RMAppAttempt state machine
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2361
>                 URL: https://issues.apache.org/jira/browse/YARN-2361
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2361.000.patch
>
>
> remove duplicate entries in the EnumSet of event type in RMAppAttempt state machine. The  event RMAppAttemptEventType.EXPIRE is duplicated in the following code.
> {code}
>           EnumSet.of(RMAppAttemptEventType.ATTEMPT_ADDED,
>               RMAppAttemptEventType.EXPIRE,
>               RMAppAttemptEventType.LAUNCHED,
>               RMAppAttemptEventType.LAUNCH_FAILED,
>               RMAppAttemptEventType.EXPIRE,
>               RMAppAttemptEventType.REGISTERED,
>               RMAppAttemptEventType.CONTAINER_ALLOCATED,
>               RMAppAttemptEventType.UNREGISTERED,
>               RMAppAttemptEventType.KILL,
>               RMAppAttemptEventType.STATUS_UPDATE))
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)