[jira] [Commented] (SPARK-13998) HashingTF should extend UnaryTransformer

["Jacek Laskowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223326#comment-15223326 ] 

Jacek Laskowski commented on SPARK-13998:
-----------------------------------------

I don't personally, but I don't really like whenever I see all these non-{{UnaryTransformer}} transformers like {{HashingTF}} or {{StopWordsRemover}} on my way. I'd like to give it a shot and get rid of the "anomaly". What is the jira for refactoring {{UnaryTransformer}} to support setting {{Attribute}}? Or perhaps [~yanboliang] wants to work on it? 

Please guide [~josephkb] / [~mlnick].

> HashingTF should extend UnaryTransformer
> ----------------------------------------
>
>                 Key: SPARK-13998
>                 URL: https://issues.apache.org/jira/browse/SPARK-13998
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML
>    Affects Versions: 2.0.0
>            Reporter: Jacek Laskowski
>            Priority: Minor
>
> Currently [HashingTF|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala#L37] extends {{Transformer with HasInputCol with HasOutputCol}}, but there is a helper [UnaryTransformer|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/Transformer.scala#L79-L80] abstract class for exactly the reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org