You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/01/10 08:41:22 UTC
[kudu-CR] WIP [util] RX and TX queue size for listened socket
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20878
Change subject: WIP [util] RX and TX queue size for listened socket
......................................................................
WIP [util] RX and TX queue size for listened socket
Socket::GetStats() had some code to report on the RX and TX queue
size for a connected socket, but it doesn't work for a listened socket.
This patch implements proper reporting on the RX and TX queue size
of a listened socket, adding new test scenarios to make sure the new
functionality works as expected.
This patch is a building block to implement a metric monitoring
the backlog of a listened Kudu server socket in a follow-up patches.
WIP:
* try to use sock_diag [1] instead of reading information from procfs
* optimize the process of finding correspondence between inode number
and socket descriptor
* address a few other TODOs in the new code
* collect feedback
[1] https://man7.org/linux/man-pages/man7/sock_diag.7.html
Change-Id: I1898519f75c4f89949913bd1eb8659601166ae08
---
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
7 files changed, 394 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/20878/1
--
To view, visit http://gerrit.cloudera.org:8080/20878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1898519f75c4f89949913bd1eb8659601166ae08
Gerrit-Change-Number: 20878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] WIP [util] RX and TX queue size for listened socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20878
to look at the new patch set (#2).
Change subject: WIP [util] RX and TX queue size for listened socket
......................................................................
WIP [util] RX and TX queue size for listened socket
Socket::GetStats() had some code to report on the RX and TX queue
size for a connected socket, but it doesn't work for a listened socket.
This patch implements proper reporting on the RX and TX queue size
of a listened socket, adding new test scenarios to make sure the new
functionality works as expected.
This patch is a building block to implement a metric monitoring
the backlog of a listened Kudu server socket in a follow-up patches.
WIP:
* try to use sock_diag [1] instead of reading information from procfs
* optimize the process of finding correspondence between inode number
and socket descriptor
* address a few other TODOs in the new code
* collect feedback
[1] https://man7.org/linux/man-pages/man7/sock_diag.7.html
Change-Id: I1898519f75c4f89949913bd1eb8659601166ae08
---
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
7 files changed, 355 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/20878/2
--
To view, visit http://gerrit.cloudera.org:8080/20878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1898519f75c4f89949913bd1eb8659601166ae08
Gerrit-Change-Number: 20878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [util] RX and TX queue size for listened socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/20878 )
Change subject: WIP [util] RX and TX queue size for listened socket
......................................................................
Abandoned
Superseded by http://gerrit.cloudera.org:8080/20892
--
To view, visit http://gerrit.cloudera.org:8080/20878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1898519f75c4f89949913bd1eb8659601166ae08
Gerrit-Change-Number: 20878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)