You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "LegGasai (via GitHub)" <gi...@apache.org> on 2024/12/01 10:51:41 UTC
[PR] optimize: alter the print info in ConfigurationFactory.java when load ExtConfiguration [incubator-seata]
LegGasai opened a new pull request, #7040:
URL: https://github.com/apache/incubator-seata/pull/7040
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
#6956
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: alter the print info in ConfigurationFactory.java when load ExtConfiguration [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #7040:
URL: https://github.com/apache/incubator-seata/pull/7040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: alter the print info in ConfigurationFactory.java when load ExtConfiguration [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7040:
URL: https://github.com/apache/incubator-seata/pull/7040#issuecomment-2509706324
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 52.83%. Comparing base [(`3bfc206`)](https://app.codecov.io/gh/apache/incubator-seata/commit/3bfc206a0783acbb44cbe952504572b8b7d7bde9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c41f1b6`)](https://app.codecov.io/gh/apache/incubator-seata/commit/c41f1b62b26792dea96536085a6a33fd4a1b171c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on 2.x.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/seata/config/ConfigurationFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?src=pr&el=tree&filepath=config%2Fseata-config-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2FConfigurationFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb25maWcvQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #7040 +/- ##
============================================
+ Coverage 52.58% 52.83% +0.25%
- Complexity 6615 6656 +41
============================================
Files 1128 1128
Lines 40142 40142
Branches 4707 4705 -2
============================================
+ Hits 21108 21210 +102
+ Misses 17020 16920 -100
+ Partials 2014 2012 -2
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/seata/config/ConfigurationFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7040?src=pr&el=tree&filepath=config%2Fseata-config-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2FConfigurationFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb25maWcvQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `39.47% <0.00%> (ø)` | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7040/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org