You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 07:12:44 UTC
[GitHub] [spark-website] gengliangwang opened a new pull request #359: New home page and layout for Spark website
gengliangwang opened a new pull request #359:
URL: https://github.com/apache/spark-website/pull/359
This PR introduces a new UI for the Spark Website, including:
* A new home page
* A new global layout template
* Update title case capitalization of each page
To preview the new website, check http://ec2-54-184-63-212.us-west-2.compute.amazonaws.com
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] zero323 commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-940094553
Looks nice, but I am bit concerned about the contrast ratio. If we had
```css
body {
color: #555555;
...
}
```
it should still look good, IMHO, but exceed WCAG AAA on normal text (going from 5.74:1 to 7.45:1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-939752932
cc @mateiz @rxin @gatorsmile @srowen @cloud-fan @HyukjinKwon @dongjoon-hyun @holdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-941194036
Merged. Thanks all for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HeartSaVioR commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-941878858
Late LGTM. Looks nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] dongjoon-hyun commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-940343032
New look is very impressive, @gengliangwang . :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-940153938
@zero323 Thanks for the suggestion. Even though it fails WCAG AAA, but it still passes WCAG AA. I prefer the current color (#666666) since it looks more comfortable on my first impression.
I made two screenshots. If there are more suggestions to change the color, I will update it.
`#666666`
`#555555`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HeartSaVioR commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-941878858
Late LGTM. Looks nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] mateiz commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
mateiz commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-940680134
This looks great to me, very excited about it. We should definitely keep improving it over time, for instance with better code examples and setup instructions in all the languages if applicable. My only comment on that is to make sure to keep the first example people see small. The other tabs can contain more stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] yaooqinn commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-940778866
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang merged pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang merged pull request #359:
URL: https://github.com/apache/spark-website/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang merged pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang merged pull request #359:
URL: https://github.com/apache/spark-website/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] gengliangwang commented on pull request #359: New home page and layout for Spark website
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #359:
URL: https://github.com/apache/spark-website/pull/359#issuecomment-941194036
Merged. Thanks all for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org