You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nick Dimiduk (JIRA)" <ji...@apache.org> on 2013/03/12 02:19:12 UTC

[jira] [Updated] (HBASE-7995) Export$Exporter could be replaced with IdentityTableMapper

     [ https://issues.apache.org/jira/browse/HBASE-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Dimiduk updated HBASE-7995:
--------------------------------

    Attachment: 0001-HBASE-7995-Replace-Export-Exporter-with-IdentityTabl.patch

A pretty simple patch. `mvn clean compile test -Dtest=TestImportExport` succeeds.
                
> Export$Exporter could be replaced with IdentityTableMapper
> ----------------------------------------------------------
>
>                 Key: HBASE-7995
>                 URL: https://issues.apache.org/jira/browse/HBASE-7995
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>         Attachments: 0001-HBASE-7995-Replace-Export-Exporter-with-IdentityTabl.patch
>
>
> The Mapper implementation in Export looks identical to IdentityTableMapper, except for the (poor) exception handling. I'd like to consolidate on IdentityTableMapper, but I'm looking for some historical perspective before doing so (cc [~stack])
> Export$Exporter's map method:
> {code}
>     public void map(ImmutableBytesWritable row, Result value, Context context)
>     throws IOException {
>       try {
>         context.write(row, value);
>       } catch (InterruptedException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> IdentityTableMapper's map method:
> {code}
>   public void map(ImmutableBytesWritable key, Result value, Context context)
>   throws IOException, InterruptedException {
>     context.write(key, value);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira