You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2014/11/26 17:47:35 UTC
[GitHub] incubator-brooklyn-site pull request: Navigation improvements
GitHub user rdowner opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/15
Navigation improvements
Fixes a couple of niggles with the site navigation.
* Nav bar pop-downs clear identify the nav item's top-level page
* Site navigation can now include links to non-Jekyll-managed pages, such as the user guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/incubator-brooklyn-site navigation-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn-site/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 6dc6bde1940ac7d3aa348e4e048e7f231a158ae9
Author: Richard Downer <ri...@apache.org>
Date: 2014-11-26T16:28:44Z
Allow menus to include hyperlinks
Menus were only allowed to link to other Jekyll-managed pages. This
allows hyperlinks to non-Jekyll-managed pages to be used. Currently, the
links must still be on the same site.
commit 8f7a85ad079e74c95f2e9cc6cf27cee605971867
Author: Richard Downer <ri...@apache.org>
Date: 2014-11-26T16:42:34Z
Nav submenus also include the top item
Previously, hovering over the 'documentation' nav item (as an example)
would reveal a pop-down menu. But it was not clear that the
'documentation' item itself had a page, meaning sometimes people would
miss the content. This adds the 'documentation' item itself to the
pop-down menu.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn-site pull request: Navigation improvements
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/15#issuecomment-66976758
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn-site pull request: Navigation improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn-site/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---