You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2022/06/03 17:13:00 UTC
[jira] [Commented] (BEAM-1692) Convert to Codahale Metric interfaces where possible in WithMetricsSupport MetricRegistry
[ https://issues.apache.org/jira/browse/BEAM-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17546368#comment-17546368 ]
Kenneth Knowles commented on BEAM-1692:
---------------------------------------
This issue has been migrated to https://github.com/apache/beam/issues/18240
> Convert to Codahale Metric interfaces where possible in WithMetricsSupport MetricRegistry
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-1692
> URL: https://issues.apache.org/jira/browse/BEAM-1692
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Aviem Zur
> Priority: P3
>
> Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}} metrics.
> Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}} but this is a hack and should be avoided if possible.
> Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters where possible.
> Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs and stay with a simple {{Gauge}}.
> Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)