You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by navis <gi...@git.apache.org> on 2015/04/29 06:35:50 UTC

[GitHub] tajo pull request: TAJO-1577 Add test cases to verify join plans

GitHub user navis opened a pull request:

    https://github.com/apache/tajo/pull/558

    TAJO-1577 Add test cases to verify join plans

    @jihoonson Could you review this? If it's done in right way, I'll apply this to all tests in Test*JoinQuery

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navis/tajo TAJO-1577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 97e31a9c6dc7bf327877b3959b3f56d0374bd58b
Author: navis.ryu <na...@apache.org>
Date:   2015-04-29T04:33:03Z

    TAJO-1577 Add test cases to verify join plans

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1577 Add test cases to verify join plans

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/558#issuecomment-97304693
  
    Thanks @navis. I'll roughly review right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1577 Add test cases to verify join plans

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1577 Add test cases to verify join plans

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/558#issuecomment-97308878
  
    Looks great! The test failure is due to the too much memory usage in python udfs. It's my fault. Sorry.
    This problem will be solved if you rebase.
    
    I have one suggestion. Even though the annotation name is ```SimpleTest```, it looks very proper for our all query tests. 
    I think that we should test more complex and long queries. For such queries, it would be difficult to write sqls in the ```SimpleTest``` annotation. How about extending it to support sql files like the current query tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---