You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/19 22:34:57 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#discussion_r315440404
##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -235,123 +231,22 @@ public FileEncryptionInfo getFileEncryptionInfo() {
return encInfo;
}
- public List<OzoneAclInfo> getAcls() {
+ public List<OzoneAcl> getAcls() {
Review comment:
We can leave this as OzoneAclInfo, and make OmBucketInfo OzoneAcl -> OzoneAclInfo.
In this way, we can avoid conversion of OzoneAcl list during OM operations.
And this will be useful in HA code path, as we operate directly OMRequest objects. (I mean here we get the data from OMRequest, and perform operation and store in cache)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org